Fix test

Test dataframe had time_value in the wrong type, should be datetime.date

Author: qx-teo

_delphi_utils_python/delphi_utils/validator/dynamic.py

@@ -183,18 +183,18 @@ def check_na_vals(self, geo_sig_df, geo_type, signal_type, report):
         Returns:
             - None
         """
-        def replace_first_six(df):
+        def replace_first_six(df, start_date):
             x = df.val.isnull()
             # First 6 days have to be null
             x.iloc[:6] = False
-            return df.time_value[x]
+            df = df[x]
+            return df.time_value[df.time_value >= start_date]
 
         grouped_df = geo_sig_df.groupby('geo_id')
-        error_df = grouped_df.apply(replace_first_six)
+        error_df = grouped_df.apply(replace_first_six,
+            start_date = self.params.time_window.start_date)
 
         if not error_df.empty:
-            error_df = error_df[error_df.time_value >=
-                self.params.time_window.start_date]
             for index, value in error_df.iteritems():
                 report.add_raised_error(
                     ValidationFailure("check_val_missing",

_delphi_utils_python/delphi_utils/validator/validate.py

@@ -57,7 +57,7 @@ def validate(self):
         report = ValidationReport(self.suppressed_errors, self.data_source, self.dry_run)
         frames_list = load_all_files(self.export_dir, self.time_window.start_date,
                                      self.time_window.end_date)
-        #self.static_validation.validate(frames_list, report)
+        self.static_validation.validate(frames_list, report)
         all_frames = aggregate_frames(frames_list)
         self.dynamic_validation.validate(all_frames, report)
         return report

_delphi_utils_python/tests/validator/test_dynamic.py

@@ -120,10 +120,8 @@ def test_missing(self):
         data = {"val": [np.nan] * 15, "geo_id": [0,1] * 7 + [2], 
             "time_value": ["2021-08-30"] * 14 + ["2021-05-01"]}
         df = pd.DataFrame(data)
-        #df.set_index(range(7), inplace=True)
+        df.time_value = (pd.to_datetime(df.time_value)).dt.date
         validator.check_na_vals(df, "geo", "signal", report)
-        import pdb
-        pdb.set_trace()
 
         assert len(report.raised_errors) == 2
         assert report.raised_errors[0].check_name == "check_val_missing"