refactor: update const name

Author: BioPhoton

packages/utils/src/lib/profiler/constants.ts

@@ -36,4 +36,4 @@ export const PROFILER_PERSIST_BASENAME = 'trace';
  * Name for current measure.
  * Used as the name for the sharded folder.
  */
-export const PROFILER_MEASURE_NAME = 'CP_PROFILER_MEASURE_NAME';
+export const PROFILER_MEASURE_NAME_ENV_VAR = 'CP_PROFILER_MEASURE_NAME';

packages/utils/src/lib/wal-sharded.unit.test.ts

@@ -3,7 +3,7 @@ import { beforeEach, describe, expect, it } from 'vitest';
 import { MEMFS_VOLUME, osAgnosticPath } from '@code-pushup/test-utils';
 import { getUniqueInstanceId } from './process-id.js';
 import {
-  PROFILER_MEASURE_NAME,
+  PROFILER_MEASURE_NAME_ENV_VAR,
   SHARDED_WAL_COORDINATOR_ID_ENV_VAR,
 } from './profiler/constants.js';
 import { ShardedWal } from './wal-sharded.js';
@@ -46,7 +46,7 @@ describe('ShardedWal', () => {
     delete process.env[SHARDED_WAL_COORDINATOR_ID_ENV_VAR];
     // Clear measure name env var to avoid test pollution
     // eslint-disable-next-line functional/immutable-data
-    delete process.env[PROFILER_MEASURE_NAME];
+    delete process.env[PROFILER_MEASURE_NAME_ENV_VAR];
   });
 
   describe('initialization', () => {
@@ -63,19 +63,17 @@ describe('ShardedWal', () => {
 
     it('should use groupId from env var when measureNameEnvVar is set', () => {
       // eslint-disable-next-line functional/immutable-data
-      process.env[PROFILER_MEASURE_NAME] = 'from-env';
+      vi.stubEnv(PROFILER_MEASURE_NAME_ENV_VAR, 'from-env');
       const sw = getShardedWal({
-        measureNameEnvVar: PROFILER_MEASURE_NAME,
+        measureNameEnvVar: PROFILER_MEASURE_NAME_ENV_VAR,
       });
       expect(sw.groupId).toBe('from-env');
       expect(process.env.CP_PROFILER_MEASURE_NAME).toBe('from-env');
     });
 
     it('should set env var when measureNameEnvVar is provided and unset', () => {
-      // eslint-disable-next-line functional/immutable-data
-      delete process.env.CP_PROFILER_MEASURE_NAME;
       const sw = getShardedWal({
-        measureNameEnvVar: PROFILER_MEASURE_NAME,
+        measureNameEnvVar: PROFILER_MEASURE_NAME_ENV_VAR,
       });
       expect(process.env.CP_PROFILER_MEASURE_NAME).toBe(sw.groupId);
     });
@@ -139,7 +137,7 @@ describe('ShardedWal', () => {
       process.env.CP_PROFILER_MEASURE_NAME = '../malicious';
       expect(() =>
         getShardedWal({
-          measureNameEnvVar: PROFILER_MEASURE_NAME,
+          measureNameEnvVar: PROFILER_MEASURE_NAME_ENV_VAR,
         }),
       ).toThrow('groupId cannot contain path separators');
     });