Merge pull request #622 from codeRIT/hm-621

refactor: Updates check-in/out flash verbiage

Author: cbaudouinjr

app/controllers/manage/questionnaires_controller.rb

@@ -91,12 +91,12 @@ def check_in
             return
           end
           check_in_attendee
-          flash[:notice] = "Checked in #{@questionnaire.user.full_name}."
+          flash[:notice] = t(:checked_in, scope: 'messages', user_full_name: @questionnaire.user.full_name)
         elsif params[:check_in] == "false"
           check_out_attendee
-          flash[:notice] = "#{@questionnaire.user.full_name} no longer checked in."
+          flash[:notice] = t(:checked_out, scope: 'messages', user_full_name: @questionnaire.user.full_name)
         else
-          flash[:alert] = "No check-in action provided!"
+          flash[:alert] = t(:missing_check_in, scope: 'messages')
           redirect_to show_redirect_path
           return
         end

config/locales/en.yml

@@ -124,6 +124,10 @@ en:
         homepage_url: Homepage URL
         thanks_for_rsvp_message: Thanks For RSVP Message
         questionnaires_closed_message: Questionnaires Closed Message
+  messages:
+    checked_in: "%{user_full_name} has been checked in."
+    checked_out: "%{user_full_name} is no longer checked in."
+    missing_check_in: No check-in action provided!
   pages:
     manage:
       dashboard:

test/controllers/manage/questionnaires_controller_test.rb

@@ -363,7 +363,7 @@ class Manage::QuestionnairesControllerTest < ActionController::TestCase
       patch :check_in, params: { id: @questionnaire, check_in: "true" }, format: :html
       assert 1.minute.ago < @questionnaire.reload.checked_in_at
       assert_equal @user.id, @questionnaire.reload.checked_in_by_id
-      assert_match /Checked in/, flash[:notice]
+      assert_match /has been checked in./, flash[:notice]
       assert_response :redirect
       assert_redirected_to manage_questionnaires_path
     end
@@ -401,7 +401,7 @@ class Manage::QuestionnairesControllerTest < ActionController::TestCase
       assert_equal true, @questionnaire.can_share_info
       assert_equal "1233333333", @questionnaire.phone
       assert_equal "[email protected]", @questionnaire.email
-      assert_match /Checked in/, flash[:notice]
+      assert_match /has been checked in./, flash[:notice]
       assert_response :redirect
       assert_redirected_to manage_questionnaires_path
     end