feat: Updates HackathonManager 2.1.1

* fix(questionnaire): missing information now in correct place (#443)

* fix(questionnair): missing information now in correct place

it now displays the correct message "Please read & accept" instead of
missing information and the notification is now in the correct place

* Update app/assets/javascripts/validate.js

* Revert "Update app/assets/javascripts/validate.js"

This reverts commit bc54783.

Signed-off-by: Peter Kos <[email protected]>

Co-authored-by: Peter Kos <[email protected]>

* fix: Fixes mobile agreements layout bug

Signed-off-by: Peter Kos <[email protected]>

* feat: Removes semantic-release (#446)

* refactor: Moves CI to develop branch (#449)

Co-authored-by: Peter Kos <[email protected]>

Co-authored-by: JeremyRudman <[email protected]>
Co-authored-by: Peter Kos <[email protected]>

Author: 3 people

.github/workflows/build.yml

@@ -9,7 +9,9 @@ name: Build - 2.6, 2.5
 
 on:
   pull_request:
-    branches: [ master, "2.1" ]
+    branches:
+      - master
+      - develop
 
 jobs:
   build:

.github/workflows/release.yml

@@ -22,9 +22,9 @@ document.addEventListener('turbolinks:load', function() {
                 $(this)
                   .parent()
                   .text()
-                  .includes('I accept')
+                  .includes('I read and accept')
               ) {
-                notify(this, 'Please read & accept');
+                notify(".agreement_input", 'Please read & accept');
               } else {
                 notify(this, 'Missing Information');
               }
@@ -79,6 +79,13 @@ document.addEventListener('turbolinks:load', function() {
           .fadeOut(200, function() {
             $(this).remove();
           });
+        $(".agreement_input")
+          .parent()
+          .removeClass('field_with_errors')
+          .find('.error')
+          .fadeOut(200, function() {
+            $(this).remove();
+          });
       }
       return success;
     };

app/assets/javascripts/validate.js

@@ -8,6 +8,6 @@ class Agreement < ApplicationRecord
   has_and_belongs_to_many :questionnaires
 
   def formatted_agreement
-    "I read and accept the&nbsp;#{link_to name, agreement_url, target: '_blank'}&nbsp;agreement.".html_safe
+    "<p>I read and accept the&nbsp;#{link_to name, agreement_url, target: '_blank'}&nbsp;agreement.</p>".html_safe
   end
 end

app/models/agreement.rb

@@ -52,7 +52,8 @@
         %strong Agreements
         %p Please review the agreements and click the corresponding checkbox next to each agreement to agree.
         .form-inputs
-          = f.association :agreements, as: :check_boxes, label_method: :formatted_agreement, value_method: :id, label: "", wrapper_html: { style: 'display: block' }, input_html: { "data-validate" => "presence" }
+          .agreement_input
+            = f.association :agreements, as: :check_boxes, label_method: :formatted_agreement, value_method: :id, label: "", wrapper_html: { style: 'display: block' }, input_html: { "data-validate" => "presence" }
 
       .right
         %button.button{ type: "button", "data-wizard" => "previous" } Previous