Skip to content

Commit 571d7d7

Browse files
authored
Merge pull request #1 from MikeRogers0/bug/fix-redis-warning
fix: Redis exists? deprecation warning
2 parents 7ca90f9 + 9957edc commit 571d7d7

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lib/sidekiq/cron/job.rb

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ class Job
1414
REMEMBER_THRESHOLD = 24 * 60 * 60
1515
LAST_ENQUEUE_TIME_FORMAT = '%Y-%m-%d %H:%M:%S %z'
1616

17+
# Use the exists? method if we're on a newer version of redis.
18+
REDIS_EXISTS_METHOD = Gem.loaded_specs['redis'].version < Gem::Version.new('4.2') ? :exists : :exists?
19+
1720
#crucial part of whole enquing job
1821
def should_enque? time
1922
enqueue = false
@@ -461,7 +464,7 @@ def save
461464

462465
#add information about last time! - don't enque right after scheduler poller starts!
463466
time = Time.now.utc
464-
conn.zadd(job_enqueued_key, time.to_f.to_s, formated_last_time(time).to_s) unless conn.exists(job_enqueued_key)
467+
conn.zadd(job_enqueued_key, time.to_f.to_s, formated_last_time(time).to_s) unless conn.public_send(REDIS_EXISTS_METHOD, job_enqueued_key)
465468
end
466469
logger.info { "Cron Jobs - add job with name: #{@name}" }
467470
end
@@ -540,7 +543,7 @@ def formated_last_time now = Time.now.utc
540543
def self.exists? name
541544
out = false
542545
Sidekiq.redis do |conn|
543-
out = conn.exists redis_key name
546+
out = conn.public_send(REDIS_EXISTS_METHOD, redis_key(name))
544547
end
545548
out
546549
end

0 commit comments

Comments
 (0)