Merge pull request sidekiq-cron#246 from spk/empty-file

Check its an hash on load from hash to avoid errors

Author: ondrejbartas

lib/sidekiq/cron/job.rb

@@ -150,6 +150,7 @@ def active_job_message
       # }
       #
       def self.load_from_hash hash
+        return [] unless hash.is_a?(Hash)
         array = hash.inject([]) do |out,(key, job)|
           job['name'] = key
           out << job
@@ -160,6 +161,7 @@ def self.load_from_hash hash
       # like to {#load_from_hash}
       # If exists old jobs in redis but removed from args, destroy old jobs
       def self.load_from_hash! hash
+        return [] unless hash.is_a?(Hash)
         destroy_removed_jobs(hash.keys)
         load_from_hash(hash)
       end

test/unit/job_test.rb

@@ -955,6 +955,20 @@
         assert_equal out.size, 0, "should have no errors"
         assert_equal Sidekiq::Cron::Job.all.size, 2, "Should have 2 jobs after load"
       end
+
+      describe 'errors' do
+        describe 'not a hash' do
+          before do
+            @jobs_hash = YAML.load_file('/dev/null') # => false
+          end
+
+          it 'do not create jobs and do not fail' do
+            assert_equal Sidekiq::Cron::Job.all.size, 0, "Should have 0 jobs before load"
+            out = Sidekiq::Cron::Job.load_from_hash! @jobs_hash
+            assert_equal out.size, 0, "should have no errors"
+          end
+        end
+      end
     end
 
     describe "from array" do