Skip to content

Improvements to Null values handling #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improvements to Null values handling #409

wants to merge 7 commits into from

Conversation

dferrand
Copy link
Contributor

@dferrand dferrand commented Jun 9, 2025

Multiple changes to null value handling:

@worksofliam worksofliam self-requested a review June 10, 2025 13:00
worksofliam
worksofliam requested changes Jun 18, 2025
View reviewed changes
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality is excellent! I love the Shift+Enter notice. Here are a couple of things I noticed:

Looks like some css issues with the columns:

image

When applying null, the font is not set to monospace as the other columns are, though it's not consistant:

image

@dferrand
Copy link
Contributor Author

I made a few more changes:

  • Fixed the css issues
  • fixed the font
  • column widths on result set are now adjustable. If you double click on the width adjustement handle, it will auto adjust the width to the content
  • You can now choose to display both column name and label in the header

@dferrand dferrand requested a review from worksofliam June 23, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam Awaiting requested review from worksofliam

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX: update mode output formatting does not refresh when _null_ value is changed UX: No obvious way to enter null value when in update mode
2 participants
@dferrand @worksofliam