Add error decoration for invalid libraries in the library list #2933
Conversation
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
|
👋 A new build is available for this PR based on ff28e6f. |
There was a problem hiding this comment.
@SanjulaGanepola Great PR, learned some new stuff about decorators. 😃
Almost there, see other comment.
Signed-off-by: Sanjula Ganepola <[email protected]>
|
@chrjorgensen Ready for review again! |
chrjorgensen
left a comment
chrjorgensen
left a comment
There was a problem hiding this comment.
One issue found - see comment.
And we should not ask for adding the new library to the library list, if it's already there... right?
| if (isSuccess) { | ||
| const config = connection.getConfig(); | ||
| const libraryList = [config.currentLibrary, ...config.libraryList].map(library => library.toUpperCase()); | ||
| if (libraryList.includes(newLibrary)) { |
There was a problem hiding this comment.
This does not work if the library created is not entered in uppercase...
| if (libraryList.includes(newLibrary)) { | |
| const libraryList = [config.currentLibrary, ...config.libraryList].map(library => connection.upperCaseName(library)); | |
| if (libraryList.includes(connection.upperCaseName(newLibrary))) { |
There was a problem hiding this comment.
Careful not to use to uppercase on an object name! Use the connection upperCase method to avoid breaking variant characters like 'à' that must no be uppercased.
There was a problem hiding this comment.
Perfect! CCSID 297 users thank you! 😁
Changes
libraryicon to libraries in the library listHow to test this PR
Checklist