Skip to content

Commit 7de1f25

Browse files
authored
Merge pull request #308 from dblock/danger-pr-comment
Migrate Danger to use danger-pr-comment workflow
2 parents 2b34b4b + dc21e63 commit 7de1f25

File tree

5 files changed

+25
-20
lines changed

5 files changed

+25
-20
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
name: Danger Comment
2+
3+
on:
4+
workflow_run:
5+
workflows: [Danger]
6+
types: [completed]
7+
8+
jobs:
9+
comment:
10+
uses: numbata/danger-pr-comment/.github/workflows/danger-comment.yml@v0.1.0
11+
secrets: inherit

.github/workflows/danger.yml

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
1-
---
2-
name: danger
1+
name: Danger
2+
33
on:
44
pull_request:
55
types: [opened, reopened, edited, synchronize]
6+
67
jobs:
78
danger:
8-
runs-on: ubuntu-latest
9-
steps:
10-
- uses: actions/checkout@v3
11-
with:
12-
fetch-depth: 0
13-
- name: Set up Ruby
14-
uses: ruby/setup-ruby@v1
15-
with:
16-
ruby-version: 3.4
17-
bundler-cache: true
18-
- name: Run Danger
19-
run: |
20-
# the personal token is public, this is ok, base64 encode to avoid tripping Github
21-
TOKEN=$(echo -n Z2hwX0xNQ3VmanBFeTBvYkZVTWh6NVNqVFFBOEUxU25abzBqRUVuaAo= | base64 --decode)
22-
DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose
9+
uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0
10+
secrets: inherit
11+
with:
12+
ruby-version: '3.4'
13+
bundler-cache: true

Dangerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
1+
danger.import_dangerfile(gem: 'danger-pr-comment')
2+
13
changelog.check!
24
toc.check!

Gemfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ group :development, :test do
2121
end
2222

2323
group :test do
24-
gem 'danger-changelog', '~> 0.7.0'
24+
gem 'danger', '~> 9.5'
25+
gem 'danger-changelog', '~> 0.8.0'
26+
gem 'danger-pr-comment', '~> 0.1.0'
2527
gem 'danger-toc', '~> 0.2.0'
2628
gem 'minitest'
2729
gem 'mocha'

test/test_helper.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,13 @@
1717

1818
require 'minitest/autorun'
1919
require 'minitest/pride'
20-
require 'minitest/unit'
2120
require 'mocha/minitest'
2221
require 'json'
2322

2423
require 'faraday'
2524
require 'faraday/request/instrumentation'
2625

27-
MiniTest::Assertions.class_eval do
26+
Minitest::Assertions.class_eval do
2827
def stub_request(conn, adapter_class = Faraday::Adapter::Test, &stubs_block)
2928
adapter_handler = conn.builder.handlers.find { |h| h.klass < Faraday::Adapter }
3029
if adapter_handler

0 commit comments

Comments
 (0)