🤖 fix: support SSH workspaces in Open Terminal button #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ibetitsmike
reviewed
Nov 12, 2025
ethanndickson
force-pushed
the
remote-terminal
branch
from
7bee2d3 to
0360d52
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
- Change IPC handler to accept workspaceId instead of workspacePath - Look up workspace metadata to determine if SSH or local - For SSH: spawn local terminal that runs 'ssh -t host "cd path && exec $SHELL"' - For local: spawn terminal with cwd set (existing behavior) - Support SSH options: port (-p), identity file (-i) - Handle all platforms: macOS (Ghostty, Terminal.app), Windows (cmd), Linux (9+ terminal emulators) - Update all callers to pass workspaceId instead of path Generated with `cmux`
Fixes P1 issue where nested single quotes in the remote command would break Terminal.app's AppleScript parsing. Now uses proper shell escaping: 'foo'\''bar' Generated with `cmux`
Ghostty on macOS requires: open -n -a Ghostty --args --command="ssh ..." instead of passing SSH args directly. Generated with `cmux`
Use multi-line AppleScript with activate and end tell: tell application "Terminal" activate do script "ssh ..." end tell Generated with `cmux`
The isSSH check already validates runtimeConfig.type === "ssh", so the redundant check in the if condition is unnecessary. Generated with `cmux`
Added isSSHRuntime() type guard to RuntimeConfig that provides proper type narrowing, replacing manual type === 'ssh' checks. Generated with `cmux`
The previous commit referenced isSSHRuntime but the function wasn't actually added to the file. Generated with `cmux`
Generated with `cmux`
Applied isSSHRuntime() to RuntimeBadge, GitStatusStore, and ipcMain to replace manual type === 'ssh' checks with type-safe guards. Generated with `cmux`
Store config.type === 'ssh' check in isSSH constant at the start of openTerminal() to avoid multiple type checks throughout. Generated with `cmux`
Use the type guard function instead of manual type === 'ssh' check for consistency with the rest of the codebase. Generated with `cmux`
The config parameter in openTerminal has a different shape than RuntimeConfig (workspacePath vs srcBaseDir), so we can't use the isSSHRuntime type guard here. Generated with `cmux`
ethanndickson
force-pushed
the
remote-terminal
branch
from
219fb7b to
3c6830c
Compare
After rebase, getAllWorkspaceMetadata() is now async. Generated with `cmux`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "Open Terminal" button for SSH workspaces, which was failing with ENOENT errors because it tried to open a local path that doesn't exist locally.
Changes
The IPC handler now accepts
workspaceIdinstead ofworkspacePath, looks up the workspace metadata, and spawns the appropriate terminal:ssh -t <host> 'cd <path> && exec $SHELL'-p), identity file (-i)All callers updated to pass
workspaceIdinstead ofnamedWorkspacePath.Testing
make typecheckpasses ✅Generated with
cmux