🤖 fix: Ctrl+C no longer interrupts stream when text is selected #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Ctrl+C would interrupt the stream if the user was not in an editable element, even if they had text selected elsewhere in the chat (e.g., in message content).
Problem
The condition
(!inEditableElement || !hasSelection)would interrupt when:This meant selecting text in chat messages and pressing Ctrl+C to copy would incorrectly interrupt the stream.
Solution
Simplified the logic to
!hasSelection- now it always checks for text selection anywhere on the page, regardless of whether the user is in an editable element.Verification
Behavior now:
Generated with
cmux