PR fixes

Author: Emyrk

storage/artifactory.go

@@ -288,7 +288,7 @@ func (s *Artifactory) AddExtension(ctx context.Context, manifest *VSIXManifest,
 // going to Artifactory for the VSIX when it is missing on disk (basically
 // using the disk as a cache).
 func (s *Artifactory) Open(ctx context.Context, fp string) (fs.File, error) {
-	resp, code, err := s.request(ctx, http.MethodGet, path.Join(s.repo, fp), nil)
+	resp, code, err := s.read(ctx, path.Join(s.repo, fp))
 	if err != nil {
 		switch code {
 		case http.StatusNotFound:
@@ -301,7 +301,7 @@ func (s *Artifactory) Open(ctx context.Context, fp string) (fs.File, error) {
 	}
 
 	f := mem.NewFileHandle(mem.CreateFile(fp))
-	_, err = io.Copy(f, resp.Body)
+	_, err = io.Copy(f, resp)
 	if err != nil {
 		return nil, err
 	}

storage/local.go

@@ -129,7 +129,7 @@ func (s *Local) AddExtension(ctx context.Context, manifest *VSIXManifest, vsix [
 
 	for _, file := range extra {
 		path := filepath.Join(dir, file.RelativePath)
-		err := os.MkdirAll(filepath.Dir(path), 0o644)
+		err := os.MkdirAll(filepath.Dir(path), 0o755)
 		if err != nil {
 			return "", err
 		}

storage/signature.go

@@ -93,7 +93,7 @@ func (s *Signature) Manifest(ctx context.Context, publisher, name string, versio
 //
 //   - VSCodium requires a signature to exist, but it does appear to actually read
 //     the signature. Meaning the signature could be empty, incorrect, or a
-//     picture of cat and it would work. There is so signature verification.
+//     picture of cat and it would work. There is no signature verification.
 //
 //   - VSCode requires a signature payload to exist, but the context appear
 //     to be somewhat optional.

storage/storage_test.go

@@ -15,7 +15,6 @@ import (
 	"strconv"
 	"testing"
 
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/coder/code-marketplace/storage"
@@ -338,9 +337,7 @@ func testManifest(t *testing.T, factory storageFactory) {
 				if f.expectedManifest != nil {
 					f.expectedManifest(test.expected)
 				}
-				if !assert.Equal(t, test.expected, manifest) {
-					fmt.Println("Asd")
-				}
+				require.Equal(t, test.expected, manifest)
 			}
 		})
 	}