Skip to content

Commit 3f23840

Browse files
committed
Remove import from express-serve-static-core
Mostly because express-serve-static-core is an implicit dependency. We could make it explicit, but the type we imported from it is just an alias for qs.ParsedQs anyway.
1 parent e54467f commit 3f23840

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/node/http.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import { field, logger } from "@coder/logger"
22
import * as express from "express"
3-
import * as expressCore from "express-serve-static-core"
43
import * as http from "http"
54
import * as net from "net"
6-
import * as qs from "qs"
5+
import qs from "qs"
76
import { Disposable } from "../common/emitter"
87
import { CookieKeys, HttpCode, HttpError } from "../common/http"
98
import { normalize } from "../common/util"
@@ -185,12 +184,7 @@ export const constructRedirectPath = (req: express.Request, query: qs.ParsedQs,
185184
* preserved. `to` should be a simple path without any query parameters
186185
* `override` will merge with the existing query (use `undefined` to unset).
187186
*/
188-
export const redirect = (
189-
req: express.Request,
190-
res: express.Response,
191-
to: string,
192-
override: expressCore.Query = {},
193-
): void => {
187+
export const redirect = (req: express.Request, res: express.Response, to: string, override: qs.ParsedQs = {}): void => {
194188
const query = Object.assign({}, req.query, override)
195189
Object.keys(override).forEach((key) => {
196190
if (typeof override[key] === "undefined") {

src/node/settings.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { logger } from "@coder/logger"
2-
import { Query } from "express-serve-static-core"
2+
import type { ParsedQs } from "qs"
33
import { promises as fs } from "fs"
44

55
export type Settings = { [key: string]: Settings | string | boolean | number }
@@ -52,5 +52,5 @@ export interface UpdateSettings {
5252
* Global code-server settings.
5353
*/
5454
export interface CoderSettings extends UpdateSettings {
55-
query?: Query
55+
query?: ParsedQs
5656
}

0 commit comments

Comments
 (0)