fix: url escape results url (#21)

sreya · web-flow · commit acda0a306dfd · 2024-04-19T11:09:43.000-05:00
diff --git a/jfrog/client.go b/jfrog/client.go
@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"net/url"
 	"path/filepath"
 
 	"github.com/google/go-containerregistry/pkg/name"
@@ -103,7 +104,7 @@ type Image struct {
 }
 
 func (c *client) ResultsURL(img Image, packageID string) string {
-	return fmt.Sprintf("%s/ui/scans-list/packages-scans/%s/scan-descendants/%s?package_id=%s&version=%s", c.baseURL, img.Package, img.Version, packageID, img.Version)
+	return fmt.Sprintf("%s/ui/scans-list/packages-scans/%s/scan-descendants/%s?package_id=%s&version=%s", c.baseURL, url.PathEscape(img.Package), url.PathEscape(img.Version), url.QueryEscape(packageID), url.QueryEscape(img.Version))
 }
 
 func ParseImage(image string) (Image, error) {

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import (`
`5`	`5`	`"encoding/json"`
`6`	`6`	`"fmt"`
`7`	`7`	`"net/http"`
	`8`	`+ "net/url"`
`8`	`9`	`"path/filepath"`
`9`	`10`
`10`	`11`	`"github.com/google/go-containerregistry/pkg/name"`
`@@ -103,7 +104,7 @@ type Image struct {`
`103`	`104`	`}`
`104`	`105`
`105`	`106`	`func (c *client) ResultsURL(img Image, packageID string) string {`
`106`		`- return fmt.Sprintf("%s/ui/scans-list/packages-scans/%s/scan-descendants/%s?package_id=%s&version=%s", c.baseURL, img.Package, img.Version, packageID, img.Version)`
	`107`	`+ return fmt.Sprintf("%s/ui/scans-list/packages-scans/%s/scan-descendants/%s?package_id=%s&version=%s", c.baseURL, url.PathEscape(img.Package), url.PathEscape(img.Version), url.QueryEscape(packageID), url.QueryEscape(img.Version))`
`107`	`108`	`}`
`108`	`109`
`109`	`110`	`func ParseImage(image string) (Image, error) {`