🤖 fix: surface script persist errors & avoid LLM prompt duplication

Change-Id: Ida7a74adf242613693e4f556ef7338ca2be22a5b
Signed-off-by: Thomas Kosiewski <[email protected]>

Author: ThomasK33

src/browser/utils/messages/modelMessageTransform.ts

@@ -226,15 +226,9 @@ export function transformScriptMessagesForLLM(messages: MuxMessage[]): MuxMessag
       llmContent += `\nStdout/Stderr: (no output)`;
     }
 
-    // Include MUX_OUTPUT if present
-    if (result.outputFile?.trim()) {
-      llmContent += `\nMUX_OUTPUT:\n${result.outputFile.trim()}`;
-    }
-
-    // Include MUX_PROMPT if present
-    if (result.promptFile?.trim()) {
-      llmContent += `\nMUX_PROMPT:\n${result.promptFile.trim()}`;
-    }
+    // EXCLUDE MUX_OUTPUT and MUX_PROMPT from the LLM context for the script message itself.
+    // MUX_PROMPT is sent as a separate user message by ChatInput, so including it here would be duplication.
+    // MUX_OUTPUT is intended for user toasts, not LLM context.
 
     return {
       ...msg,

src/browser/utils/messages/transformScriptMessagesForLLM.test.ts

@@ -43,7 +43,7 @@ describe("transformScriptMessagesForLLM", () => {
     }
   });
 
-  it("should include all fields (stdout, output, prompt) if present", () => {
+  it("should exclude MUX_OUTPUT and MUX_PROMPT from script execution messages (avoid duplication)", () => {
     const scriptResult: BashToolResult = {
       success: true,
       output: "stdout stuff",
@@ -79,8 +79,10 @@ describe("transformScriptMessagesForLLM", () => {
     expect(textPart.type).toBe("text");
     if (textPart.type === "text") {
       expect(textPart.text).toContain("Stdout/Stderr:\nstdout stuff");
-      expect(textPart.text).toContain("MUX_OUTPUT:\nUser toast");
-      expect(textPart.text).toContain("MUX_PROMPT:\nModel prompt");
+      expect(textPart.text).not.toContain("MUX_OUTPUT");
+      expect(textPart.text).not.toContain("User toast");
+      expect(textPart.text).not.toContain("MUX_PROMPT");
+      expect(textPart.text).not.toContain("Model prompt");
     }
   });
 });

src/node/services/ipcMain.ts

@@ -1279,6 +1279,7 @@ export class IpcMain {
               }
             } else {
               log.error("Failed to persist script execution:", appendResult.error);
+              return Err(`Failed to persist script execution: ${appendResult.error}`);
             }
 
             return Ok(enhancedResult);