🤖 fix: only send MUX_OUTPUT/MUX_PROMPT to LLM, not raw stdout

Change-Id: If5a22a790a0d8dc94255fd810c181de0c503059a
Signed-off-by: Thomas Kosiewski <[email protected]>

Author: ThomasK33

src/browser/utils/messages/modelMessageTransform.ts

@@ -209,23 +209,42 @@ export function injectModeTransition(
  * - Preserves the rest of the message structure (id, role, other metadata)
  */
 export function transformScriptMessagesForLLM(messages: MuxMessage[]): MuxMessage[] {
-  return messages.map((msg) => {
+  return messages.flatMap((msg) => {
     if (msg.metadata?.muxMetadata?.type !== "script-execution") {
-      return msg;
+      return [msg];
     }
 
     const scriptMeta = msg.metadata.muxMetadata;
-    const exitCode = scriptMeta.result.exitCode;
-    const output = scriptMeta.result.output ?? "(no output)";
+    const result = scriptMeta.result;
+    // Only include the message if the script explicitly wrote to MUX_PROMPT (promptFile)
+    // or MUX_OUTPUT (outputFile).
+    // This respects the "Visible only to you" promise for stdout/stderr (result.output).
+    const promptContent = result.promptFile?.trim();
+    const outputContent = result.outputFile?.trim();
+    const hasContent = (promptContent && promptContent.length > 0) || (outputContent && outputContent.length > 0);
 
-    // Construct a concise representation for the LLM
-    const llmContent = `Script '${scriptMeta.scriptName}' executed (exit code ${exitCode}).\nStdout/Stderr:\n${output}`;
+    if (hasContent) {
+      let llmContent = `Script '${scriptMeta.scriptName}' executed (exit code ${result.exitCode}).`;
+      
+      if (outputContent && outputContent.length > 0) {
+        llmContent += `\nMUX_OUTPUT:\n${outputContent}`;
+      }
+      
+      if (promptContent && promptContent.length > 0) {
+        llmContent += `\nMUX_PROMPT:\n${promptContent}`;
+      }
 
-    return {
-      ...msg,
-      parts: [{ type: "text", text: llmContent }],
-      // Keep metadata for debugging but ensure downstream consumers use the new parts
-    };
+      return [
+        {
+          ...msg,
+          parts: [{ type: "text", text: llmContent }],
+          // Keep metadata for debugging but ensure downstream consumers use the new parts
+        },
+      ];
+    }
+
+    // Otherwise, exclude from LLM context entirely
+    return [];
   });
 }
 

src/browser/utils/messages/transformScriptMessagesForLLM.test.ts

@@ -0,0 +1,80 @@
+import { describe, it, expect } from "@jest/globals";
+import { transformScriptMessagesForLLM } from "./modelMessageTransform";
+import type { MuxMessage } from "@/common/types/message";
+
+describe("transformScriptMessagesForLLM", () => {
+  it("should remove script execution messages that have no promptFile content", () => {
+    const messages: MuxMessage[] = [
+      {
+        id: "1",
+        role: "user",
+        parts: [{ type: "text", text: "Execute script" }],
+      },
+      {
+        id: "script-1",
+        role: "user",
+        parts: [{ type: "text", text: "Executed script: /script test" }],
+        metadata: {
+          muxMetadata: {
+            type: "script-execution",
+            id: "script-1",
+            historySequence: 0,
+            timestamp: 123,
+            command: "/script test",
+            scriptName: "test.sh",
+            args: [],
+            result: {
+              success: true,
+              output: "some stdout output",
+              exitCode: 0,
+              wall_duration_ms: 100,
+            } as any,
+          },
+        },
+      },
+    ];
+
+    const result = transformScriptMessagesForLLM(messages);
+    expect(result).toHaveLength(1);
+    expect(result[0].id).toBe("1");
+  });
+
+  it("should include script execution messages that HAVE promptFile content", () => {
+    const messages: MuxMessage[] = [
+      {
+        id: "script-1",
+        role: "user",
+        parts: [{ type: "text", text: "Executed script: /script test" }],
+        metadata: {
+          muxMetadata: {
+            type: "script-execution",
+            id: "script-1",
+            historySequence: 0,
+            timestamp: 123,
+            command: "/script test",
+            scriptName: "test.sh",
+            args: [],
+            result: {
+              success: true,
+              output: "some stdout output",
+              exitCode: 0,
+              wall_duration_ms: 100,
+              promptFile: "This is relevant for the LLM",
+            } as any,
+          },
+        },
+      },
+    ];
+
+    const result = transformScriptMessagesForLLM(messages);
+    expect(result).toHaveLength(1);
+    const textPart = result[0].parts[0];
+    expect(textPart.type).toBe("text");
+    if (textPart.type === "text") {
+       expect(textPart.text).toContain("Script 'test.sh' executed");
+       expect(textPart.text).toContain("Output:");
+       expect(textPart.text).toContain("This is relevant for the LLM");
+       expect(textPart.text).not.toContain("some stdout output");
+    }
+  });
+});