🤖 fix: use POSIX paths for scripts in SSH workspaces

Change-Id: I448a26c7e23d4c2074c19fa3cbd7b9a4e7adbbd0
Signed-off-by: Thomas Kosiewski <[email protected]>

Author: ThomasK33

src/node/services/scriptRunner.ts

@@ -1,6 +1,6 @@
 import * as path from "path";
 import { type Runtime } from "@/node/runtime/Runtime";
-import { getScriptPath } from "@/utils/scripts/discovery";
+import { getScriptPath, getScriptsDir } from "@/utils/scripts/discovery";
 import { createBashTool } from "@/node/services/tools/bash";
 import { writeFileString, readFileString, execBuffered } from "@/node/utils/runtime/helpers";
 import { Ok, Err, type Result } from "@/common/types/result";
@@ -42,7 +42,7 @@ export async function runWorkspaceScript(
   }
 
   const scriptPath = getScriptPath(workspacePath, scriptName);
-  const scriptsDir = path.join(workspacePath, ".cmux", "scripts");
+  const scriptsDir = getScriptsDir(workspacePath);
   const normalizedScriptPath = path.normalize(scriptPath);
   const normalizedScriptsDir = path.normalize(scriptsDir);
 

src/utils/scripts/discovery.test.ts

@@ -1,6 +1,7 @@
 import { describe, test, expect } from "bun:test";
 import type { Runtime } from "@/node/runtime/Runtime";
-import { listScripts } from "./discovery";
+import { listScripts, getScriptPath } from "./discovery";
+import * as path from "path";
 
 // Mock runtime for testing
 function createMockRuntime(responses: Map<string, { stdout: string; exitCode: number }>): Runtime {
@@ -215,3 +216,21 @@ describe("listScripts", () => {
     ]);
   });
 });
+
+describe("getScriptPath", () => {
+  test("uses POSIX separators for POSIX workspace paths", () => {
+    const workspacePath = "/home/user/workspace";
+    const scriptName = "test.sh";
+    // Explicitly check for forward slashes regardless of host OS
+    const expected = "/home/user/workspace/.cmux/scripts/test.sh";
+    expect(getScriptPath(workspacePath, scriptName)).toBe(expected);
+  });
+
+  test("uses host separators (default) for Windows workspace paths", () => {
+    const workspacePath = "C:\\Users\\user\\workspace";
+    const scriptName = "test.bat";
+    // Should use path.join, which depends on the host OS running the test
+    const expected = path.join(workspacePath, ".cmux", "scripts", scriptName);
+    expect(getScriptPath(workspacePath, scriptName)).toBe(expected);
+  });
+});

src/utils/scripts/discovery.ts

@@ -89,7 +89,7 @@ async function discoverScriptsInternal(
   runtime: Runtime,
   workspacePath: string
 ): Promise<ScriptInfo[]> {
-  const scriptsDir = path.join(workspacePath, ".cmux", "scripts");
+  const scriptsDir = getScriptsDir(workspacePath);
   // Unique separator unlikely to appear in filenames or output
   const separator = ":::MUX_SCRIPT_START:::";
 
@@ -212,14 +212,37 @@ function extractDescriptionFromContent(content: string): string | undefined {
   return undefined;
 }
 
+
+/**
+ * Join paths respecting the workspace path style (POSIX vs Windows).
+ * On Windows, path.join converts everything to backslashes.
+ * If workspacePath looks like POSIX (has forward slashes, no backslashes), use path.posix.
+ */
+function joinWorkspacePath(workspacePath: string, ...parts: string[]): string {
+  const isPosix = workspacePath.includes("/") && !workspacePath.includes("\\");
+  if (isPosix) {
+    return path.posix.join(workspacePath, ...parts);
+  }
+  return path.join(workspacePath, ...parts);
+}
+
+/**
+ * Get the scripts directory path
+ * @param workspacePath - Path to the workspace directory
+ * @returns Path to scripts directory
+ */
+export function getScriptsDir(workspacePath: string): string {
+  return joinWorkspacePath(workspacePath, ".cmux", "scripts");
+}
+
 /**
  * Get the full path to a script
  * @param workspacePath - Path to the workspace directory
  * @param scriptName - Name of the script file
  * @returns Full path to script
  */
 export function getScriptPath(workspacePath: string, scriptName: string): string {
-  return path.join(workspacePath, ".cmux", "scripts", scriptName);
+  return joinWorkspacePath(workspacePath, ".cmux", "scripts", scriptName);
 }
 
 /**