-
Notifications
You must be signed in to change notification settings - Fork 35
Show Remote SSH Output panel on workspace start #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bbb0391 to
92b1788
Compare
719de6f to
fe6d1dc
Compare
code-asher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not had a chance to try it yet, but it is looking really good!
code-asher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! I think we just need to tweak how we handle the timeout and error states, and then we are good to go.
e3c9e7f to
ae04b2c
Compare
…tial ones beforehand
ae04b2c to
ad6ea8c
Compare
ad6ea8c to
bc4ba72
Compare
code-asher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! I experimented with it and it has a few quirks when I try to stop my workspace while it waits for scripts, but otherwise looks excellent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the scope ballooned on this lol but this is really cool, it can handle anything thrown at it. Just noticed one more small thing where I get no agent script log the second time, but otherwise looks good!
b342a11 to
d8beda6
Compare
Closes #626