update format-go-code syntax

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>

Author: xcoulon

make/generate.mk

@@ -3,12 +3,6 @@ API_GROUPNAME=toolchain
 API_FULL_GROUPNAME=toolchain.dev.openshift.com
 API_VERSION:=v1alpha1
 
-## Location to install dependencies to
-LOCALBIN ?= $(shell pwd)/bin
-$(LOCALBIN):
-	mkdir -p $(LOCALBIN)
-
-
 ## Tool Binaries
 CONTROLLER_GEN ?= $(LOCALBIN)/controller-gen
 OPENAPI_GEN ?= $(LOCALBIN)/openapi-gen
@@ -50,10 +44,6 @@ $(OPENAPI_GEN): ## install openapi-gen locally if necessary.
 $(CRD_REF_DOCS): ## install crd-ref-docs locally if necessary.
 	GOBIN=$(LOCALBIN) $(GO) install github.com/elastic/crd-ref-docs@latest
 
-.PHONY: manifests
-manifests: $(CONTROLLER_GEN) ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
-	$(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="./api/..." output:crd:artifacts:config=config/crd/bases
-
 .PHONY: generate
 generate: generate-object generate-crd gen-crd-ref-docs generate-openapi dispatch-crds ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
 

make/go.mk

@@ -13,7 +13,10 @@ GOFORMAT_FILES := $(shell find  . -name '*.go' | grep -vEf ./make/gofmt_exclude)
 .PHONY: format-go-code
 ## Formats any go file that does not match formatting defined by gofmt
 format-go-code:
-	$(Q)gofmt -s -l -w ${GOFORMAT_FILES}
+# The + tells find to batch multiple found files into a single gofmt invocation (like xargs),
+# which is much faster than the alternative \;, which runs gofmt once per file. Removing it
+# would be a syntax error — find -exec requires either + or \; as a terminator.
+	$(Q)find . -name '*.go' -not -path '*/vendor/*' -not -path '*/.git/*' -exec gofmt -s -l -w {} +
 
 .PHONY: build
 ## Build