Parameterice slow beans and rename required to optional

Author: ogesaku

src/integrationTest/groovy/annotated/SlowBeanCreationSpec.groovy

@@ -19,15 +19,28 @@ class SlowBeanCreationSpec extends Specification {
         rootLogger.detachAppender(appender)
     }
 
-    def "should log slow bean initialization"() {
+    def "should log slow bean creation"() {
         given:
-            Context context = Context.scanPackage(annotated.samples.slow_beans.Bar)
+            Context context = Context.scanPackage(annotated.samples.slow_beans.Foo)
         when:
-            annotated.samples.slow_beans.Baz baz = context.get(annotated.samples.slow_beans.Baz)
+            context.get(annotated.samples.slow_beans.Foo)
+
+        then:
+            List<String> logs = appender.getLogsByMessagePrefix("Slow bean creation")
+            logs.size() == 2
+            logs.get(0).startsWith("[WARN] Slow bean creation. Bean: Bar")
+            logs.get(1).startsWith("[WARN] Slow bean creation. Bean: Foo")
+    }
+
+    def "should skip logging slow bean creation with custom threshold"() {
+        given:
+            Context context = Context.scanPackage(annotated.samples.slow_beans_annotated.Foo)
+        when:
+            context.get(annotated.samples.slow_beans_annotated.Foo)
 
         then:
             List<String> logs = appender.getLogsByMessagePrefix("Slow bean creation")
             logs.size() == 1
-            logs.first().startsWith("[WARN] Slow bean creation. Bean: Bar")
+            logs.get(0).startsWith("[WARN] Slow bean creation. Bean: Bar")
     }
 }

src/integrationTest/groovy/annotated/samples/config/SampleConfig.groovy

@@ -1,8 +1,8 @@
 package annotated.samples.config
 
 import com.coditory.quark.context.annotations.Bean
-import com.coditory.quark.context.annotations.Dependency
 import com.coditory.quark.context.annotations.Configuration
+import com.coditory.quark.context.annotations.Dependency
 
 @Configuration
 class SampleConfig {
@@ -25,7 +25,7 @@ class SampleConfig {
     Foo foo2(
             Bar bar,
             @Dependency("foooo") Foo foooo,
-            @Dependency(required = false) Baz baz
+            @Dependency(optional = true) Baz baz
     ) {
         return new Foo("foo2", bar)
     }

src/integrationTest/groovy/annotated/samples/named_bean/Bar.groovy

@@ -10,7 +10,7 @@ class Bar {
 
     Bar(
             @Dependency(name = "fooo") Foo foo,
-            @Dependency(name = "baaz", required = false) Baz baz
+            @Dependency(name = "baaz", optional = true) Baz baz
     ) {
         this.foo = foo
         this.baz = baz

src/integrationTest/groovy/annotated/samples/optional_bean/Bar.groovy

@@ -8,7 +8,7 @@ class Bar {
     final Foo foo;
     final Baz baz;
 
-    Bar(@Dependency(required = false) Foo foo, @Dependency(required = false) Baz baz) {
+    Bar(@Dependency(optional = true) Foo foo, @Dependency(optional = true) Baz baz) {
         this.foo = foo
         this.baz = baz
     }

src/integrationTest/groovy/annotated/samples/optional_multiple_deps/Bar.groovy

@@ -7,7 +7,7 @@ import com.coditory.quark.context.annotations.Dependency
 class Bar {
     final List<Foo> foo
 
-    Bar(@Dependency(required = false) List<Foo> foo) {
+    Bar(@Dependency(optional = true) List<Foo> foo) {
         this.foo = foo
     }
 }

src/integrationTest/groovy/annotated/samples/slow_beans_annotated/Bar.groovy

@@ -0,0 +1,4 @@
+package annotated.samples.slow_beans_annotated
+
+class Bar {
+}

src/integrationTest/groovy/annotated/samples/slow_beans_annotated/Baz.groovy

@@ -0,0 +1,9 @@
+package annotated.samples.slow_beans_annotated
+
+class Baz {
+    final annotated.samples.slow_beans_annotated.Bar bar
+
+    Baz(annotated.samples.slow_beans_annotated.Bar bar) {
+        this.bar = bar
+    }
+}

src/integrationTest/groovy/annotated/samples/slow_beans_annotated/ConfigInit.groovy

@@ -0,0 +1,24 @@
+package annotated.samples.slow_beans_annotated
+
+import com.coditory.quark.context.annotations.Bean
+import com.coditory.quark.context.annotations.Configuration
+
+@Configuration
+class ConfigInit {
+    @Bean(creationTimeMs = 100)
+    Bar bar() {
+        Thread.sleep(800)
+        return new Bar()
+    }
+
+    @Bean
+    Baz baz(Bar bar) {
+        return new Baz(bar)
+    }
+
+    @Bean(creationTimeMs = 1100)
+    Foo foo(Baz baz) {
+        Thread.sleep(1_000)
+        return new Foo(baz)
+    }
+}

src/integrationTest/groovy/annotated/samples/slow_beans_annotated/Foo.groovy

@@ -0,0 +1,16 @@
+package annotated.samples.slow_beans_annotated
+
+
+import static java.util.Objects.requireNonNull
+
+class Foo {
+    final Baz baz
+
+    Foo(Baz baz) {
+        this.baz = requireNonNull(baz)
+    }
+
+    Foo(annotated.samples.slow_beans_annotated.Bar bar) {
+        throw new IllegalStateException("This constructor should not be used")
+    }
+}

src/main/java/com/coditory/quark/context/BeanConfig.java

@@ -0,0 +1,22 @@
+package com.coditory.quark.context;
+
+import com.coditory.quark.context.annotations.Bean;
+import com.coditory.quark.context.annotations.Configuration;
+
+public record BeanConfig(boolean eager, int creationTimeMs, int creationTotalTimeMs) {
+    static final BeanConfig DEFAULT = new BeanConfig(false, -1, -1);
+
+    static BeanConfig fromAnnotationOrDefault(Bean annotation) {
+        if (annotation == null) return DEFAULT;
+        return new BeanConfig(annotation.eager(), annotation.creationTimeMs(), annotation.creationTotalTimeMs());
+    }
+
+    static BeanConfig fromAnnotationOrDefault(Configuration annotation) {
+        if (annotation == null) return DEFAULT;
+        return new BeanConfig(annotation.eager(), annotation.creationTimeMs(), annotation.creationTotalTimeMs());
+    }
+
+    BeanConfig withEager(boolean eager) {
+        return new BeanConfig(eager, creationTimeMs, creationTotalTimeMs);
+    }
+}