Skip to content

Commit d0ad7f1

Browse files
author
Ian Rose
committed
Merge branch 'main' into irose/package-sync-as-default
2 parents 1b5f171 + 73383af commit d0ad7f1

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

ci/environment-dashboard.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ dependencies:
99
- panel=0.13
1010
- coiled
1111
- dask
12+
- dask-ml
1213
- distributed
14+
- xgboost
1315
- pandas
1416
- tabulate

dashboard.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def get_test_source():
3535
if not callable(fn):
3636
continue
3737
source[f[len("tests/") :] + "::" + test] = inspect.getsource(fn)
38-
except Exception:
38+
except BaseException: # Some pytest exceptions inherit directly from BaseException
3939
pass
4040
return source
4141

detect_regressions.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@ def detect_regressions(database_file):
5454
pass
5555
else:
5656
for metric in ["duration", "average_memory", "peak_memory"]:
57-
# check that we have enough data to do some stats
58-
# currently we don't have a lot of data but eventually use 10 instead of 6.
59-
if len(df_test[metric]):
57+
# check that we have enough data to do some stats (last three plus previous ten)
58+
if len(df_test.loc[df_test[metric].notna()]) > 13:
6059
category = df_test.category.unique()[0]
6160
metric_threshold = (
6261
df_test[metric][-13:-3].mean()

0 commit comments

Comments
 (0)