Skip to content

Commit f5f51c6

Browse files
committed
fix triggering OnAdd on existing key. colyseus/schema#197
1 parent 2574274 commit f5f51c6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

haxelib.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
"license": "MIT",
55
"tags": ["multiplayer", "networking", "websockets", "netcode"],
66
"description": "Colyseus Multiplayer SDK",
7-
"version": "0.16.6",
7+
"version": "0.16.7",
88
"classPath": "src/",
9-
"releasenote": "onAuth() fix forwarding built-in auth token to server",
9+
"releasenote": "schema callbacks: fix triggering onAdd on existing key",
1010
"contributors": ["endel"],
1111
"dependencies": {
1212
"colyseus-websocket": "1.0.14",

src/io/colyseus/serializer/schema/Callbacks.hx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ class SchemaCallbacks<T> {
247247
triggerCallbacks2(callbacks, cast OPERATION.ADD, change.value, (change.dynamicIndex == null) ? change.field : change.dynamicIndex);
248248
}
249249

250-
} else if ((change.op & cast OPERATION.ADD) == OPERATION.ADD && change.previousValue == null) {
250+
} else if ((change.op & cast OPERATION.ADD) == OPERATION.ADD && change.previousValue != change.value) {
251251
// triger onAdd
252252
triggerCallbacks2(callbacks, cast OPERATION.ADD, change.value, (change.dynamicIndex == null) ? change.field : change.dynamicIndex);
253253
}

0 commit comments

Comments
 (0)