instance sharing: prevent early garbage collection

Author: endel

Assets/Colyseus/Runtime/Colyseus/Serializer/Schema/ReferenceTracker.cs

@@ -80,20 +80,23 @@ public bool Has(int refId)
         ///     Remove a reference by ID
         /// </summary>
         /// <param name="refId">The ID of the reference to remove</param>
-        public void Remove(int refId)
+        public bool Remove(int refId)
         {
             if (!refCounts.ContainsKey(refId))
             {
                 Debug.Log("trying to remove refId that doesn't exist: " + refId);
-                return;
+                return false;
             }
 
             refCounts[refId] = refCounts[refId] - 1;
 
             if (refCounts[refId] <= 0)
             {
                 deletedRefs.Add(refId);
+                return true;
             }
+
+            return false;
         }
 
         /// <summary>
@@ -118,9 +121,8 @@ public void GarbageCollection()
                             if (fieldValue is IRef)
                             {
                                 int childRefId = ((IRef)fieldValue).__refId;
-                                if (!deletedRefs.Contains(childRefId))
+                                if (!deletedRefs.Contains(childRefId) && Remove(childRefId))
                                 {
-                                    Remove(childRefId);
                                     totalDeletedRefs++;
                                 }
                             }
@@ -131,9 +133,8 @@ public void GarbageCollection()
                         ((ISchemaCollection)_ref).ForEach((key, value) =>
                         {
                             int childRefId = ((IRef)value).__refId;
-                            if (!deletedRefs.Contains(childRefId))
+                            if (!deletedRefs.Contains(childRefId) && Remove(childRefId))
                             {
-                                Remove(childRefId);
                                 totalDeletedRefs++;
                             }
                         });

Assets/Colyseus/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "io.colyseus.sdk",
-	"version": "0.16.5",
+	"version": "0.16.6",
 	"displayName": "Colyseus SDK",
 	"description": "Colyseus Multiplayer SDK for Unity",
 	"unity": "2019.1",