Modify MyRoom.ts to delete player on leave and to set state according to the online example, add dictionary key check to Callbacks.cs to prevent a KeyNotFound exception, update PlayerMovement.cs to use v.16. Sprite was missing on player, so I just assigned an existing sprite to it. modified .gitignore to exclude IntelliJ artifacts. (#241)

Co-authored-by: Joseph C Meineke <[email protected]>

Author: jmeineke

.gitignore

@@ -7,6 +7,7 @@ Server/build
 .DS_Store
 .vs/
 .vsconfig
+.idea/
 
 #Mono Project Files
 *.pidb

Assets/Colyseus/Runtime/Colyseus/Serializer/Schema/Callbacks/Callbacks.cs

@@ -250,13 +250,12 @@ protected void TriggerChanges(ref List<DataChange> allChanges)
 				//
 				// trigger onRemove on child structure.
 				//
-				if (
-					(change.Op & (byte)OPERATION.DELETE) == (byte)OPERATION.DELETE &&
-					change.PreviousValue is Schema
-				)
+				if ((change.Op & (byte)OPERATION.DELETE) == (byte)OPERATION.DELETE && change.PreviousValue is Schema)
 				{
 					Decoder.Refs.callbacks.TryGetValue(((Schema)change.PreviousValue).__refId, out var deleteCallbacks);
-					if (deleteCallbacks != null && deleteCallbacks[OPERATION.DELETE] != null)
+					if (deleteCallbacks != null
+					    && deleteCallbacks.ContainsKey(OPERATION.DELETE)
+					    && deleteCallbacks[OPERATION.DELETE] != null)
 					{
 						foreach (var callback in deleteCallbacks[OPERATION.DELETE])
 						{

Assets/Colyseus/Runtime/Example~/Scenes/Game.unity

@@ -1,56 +1,79 @@
 using System;
+using System.Threading.Tasks;
+using Colyseus;
+using Colyseus.Schema;
 using UnityEngine;
 
 public class PlayerMovement : MonoBehaviour
 {
-    public float speed = 10f;
-    private bool _moving;
-    private NetworkManager _networkManager;
-    private Vector2 _targetPosition;
-
-    public async void Start()
-    {
-        // Initialize game room.
-        _networkManager = gameObject.AddComponent<NetworkManager>();
-        await _networkManager.JoinOrCreateGame();
-        
-        // Assigning listener for incoming messages
-        _networkManager.GameRoom.OnMessage<string>("welcomeMessage", message =>
-        {
-            Debug.Log(message);
-        });
-        
-        // Set player's new position after synchronized the mouse click's position with the Colyseus server.
-        
-        _networkManager.GameRoom.State.OnChange(() =>
-        {
-            var player = _networkManager.GameRoom.State.players[_networkManager.GameRoom.SessionId];
-            _targetPosition = new Vector2(player.x, player.y);
-            _moving = true;
-        });
-
-        _networkManager.GameRoom.State.players.OnAdd((key, player) =>
-        {
-            Debug.Log($"Player {key} has joined the Game!");
-        });
-    }
-
-    private void Update()
-    {
-        if (Input.GetMouseButtonDown(0))
-        {
-            // Synchronize mouse click position with the Colyseus server.
-            _networkManager.PlayerPosition(Camera.main.ScreenToWorldPoint(Input.mousePosition));
-        }
-
-        if (_moving && (Vector2)transform.position != _targetPosition)
-        {
-            var step = speed * Time.deltaTime;
-            transform.position = Vector2.MoveTowards(transform.position, _targetPosition, step);
-        }
-        else
-        {
-            _moving = false;
-        }
-    }
-}
+	public float speed = 10f;
+	private bool _moving;
+	private NetworkManager _networkManager;
+	private Vector2 _targetPosition;
+	private StateCallbackStrategy<MyRoomState> _callBacks;
+
+	private void Awake()
+	{
+		_networkManager = gameObject.AddComponent<NetworkManager>();
+	}
+
+	private async void Start()
+	{
+		await _networkManager.JoinOrCreateGame();
+		registerListeners();
+	}
+
+	private void Update()
+	{
+		if (Input.GetMouseButtonDown(0))
+		{
+			// Synchronize mouse click position with the Colyseus server.
+			_networkManager.PlayerPosition(Camera.main.ScreenToWorldPoint(Input.mousePosition));
+		}
+
+		if (_moving && (Vector2)transform.position != _targetPosition)
+		{
+			var step = speed * Time.deltaTime;
+			transform.position = Vector2.MoveTowards(transform.position, _targetPosition, step);
+		}
+		else
+		{
+			_moving = false;
+		}
+	}
+
+	private void registerListeners()
+	{
+		// Retrieve the StateCallbackStrategy object
+		_callBacks = Callbacks.Get(_networkManager.GameRoom);
+
+		// Assign listener for incoming messages
+		_networkManager.GameRoom.OnMessage<string>("welcomeMessage", message =>
+		{
+			Debug.Log(message);
+		});
+
+		// Assign listeners for state change/add/remove
+		_networkManager.GameRoom.OnStateChange += (changedState, firstState) =>
+		{
+			if (!firstState)
+				return;
+
+			_callBacks.OnAdd(addedState => addedState.players, (sessionId, addedPlayer) =>
+			{
+				Debug.Log($"player {sessionId} joined)");
+
+				_callBacks.OnChange(addedPlayer, () =>
+				{
+					_targetPosition = new Vector2(addedPlayer.x, addedPlayer.y);
+					_moving = true;
+				});
+			});
+
+			_callBacks.OnRemove(removedState => removedState.players, (sessionId, removedPlayer) =>
+			{
+				Debug.Log($"player {sessionId} left");
+			});
+		};
+	}
+}

Assets/Colyseus/Runtime/Example~/Scripts/PlayerMovement.cs

@@ -1,6 +1,6 @@
 {
 	"name": "io.colyseus.sdk",
-	"version": "0.16.7",
+	"version": "0.16.8",
 	"displayName": "Colyseus SDK",
 	"description": "Colyseus Multiplayer SDK for Unity",
 	"unity": "2019.1",

Assets/Colyseus/Runtime/Example~/Scripts/PlayerMovement.cs.meta

@@ -8,12 +8,17 @@ export type PositionMessage = {
 
 export class MyRoom extends Room<MyRoomState> {
 
+  state = new MyRoomState();
+
   onCreate (options: any) {
-    this.setState(new MyRoomState());
+    this.setMetadata({
+      //Set room metadata here, e.g.,
+      //RoomName: options.RoomName
+    })
   }
 
   onAuth(client: Client, options: any, context: AuthContext) {
-    return false;
+    return true;
   }
 
   onJoin (client: Client, options: any) {
@@ -34,11 +39,11 @@ export class MyRoom extends Room<MyRoomState> {
   }
 
   onLeave (client: Client, consented: boolean) {
+    this.state.players.delete(client.sessionId);
     console.log(client.sessionId, "left!");
   }
 
   onDispose() {
     console.log("room", this.roomId, "disposing...");
   }
-
 }