Skip to content

Commit a7f7b17

Browse files
committed
fixes triggering OnChange. bump version
1 parent 1d79222 commit a7f7b17

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

Assets/Colyseus/Runtime/Colyseus/Serializer/Schema/Callbacks/Callbacks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ change.PreviousValue is Schema
372372
}
373373

374374
// trigger onChange
375-
if (change.Value != change.PreviousValue && change.Value != null)
375+
if (change.Value != change.PreviousValue)
376376
{
377377
callbacks.TryGetValue(OPERATION.REPLACE, out var replaceCallbacks);
378378
if (replaceCallbacks != null)

Assets/Colyseus/Tests/Editor/ColyseusTests/SchemaDeserializerTest.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,10 @@ public void MapSchemaTypesTest()
255255
Assert.AreEqual(mapOfStringsRemove, 2);
256256
Assert.AreEqual(mapOfIntRemove, 2);
257257

258-
Assert.AreEqual(mapOfSchemasChange, 3);
259-
Assert.AreEqual(mapOfNumbersChange, 3);
260-
Assert.AreEqual(mapOfStringsChange, 3);
261-
Assert.AreEqual(mapOfIntChange, 3);
258+
Assert.AreEqual(mapOfSchemasChange, 5);
259+
Assert.AreEqual(mapOfNumbersChange, 5);
260+
Assert.AreEqual(mapOfStringsChange, 5);
261+
Assert.AreEqual(mapOfIntChange, 5);
262262
}
263263

264264
[Test]
@@ -500,11 +500,11 @@ public void CallbacksTest()
500500
Assert.AreEqual(2, onListenContainer);
501501
Assert.AreEqual(4, onPlayerAdd);
502502
Assert.AreEqual(1, onPlayerRemove);
503-
Assert.AreEqual(4, onPlayerChange);
503+
Assert.AreEqual(5, onPlayerChange);
504504

505505
Assert.AreEqual(11, onItemAdd);
506506
Assert.AreEqual(2, onItemRemove);
507-
Assert.AreEqual(11, onItemChange);
507+
Assert.AreEqual(13, onItemChange);
508508
}
509509

510510
}

Assets/Colyseus/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "io.colyseus.sdk",
3-
"version": "0.16.2",
3+
"version": "0.16.3",
44
"displayName": "Colyseus SDK",
55
"description": "Colyseus Multiplayer SDK for Unity",
66
"unity": "2019.1",

0 commit comments

Comments
 (0)