fix triggering OnAdd on existing key. colyseus/schema#197

endel · endel · commit ce311c2be4dd · 2025-04-21T22:29:10.000-03:00
diff --git a/Assets/Colyseus/Runtime/Colyseus/Serializer/Schema/Callbacks/Callbacks.cs b/Assets/Colyseus/Runtime/Colyseus/Serializer/Schema/Callbacks/Callbacks.cs
@@ -351,10 +351,7 @@ protected void TriggerChanges(ref List<DataChange> allChanges)
 					}
 					else if (
 						(change.Op & (byte)OPERATION.ADD) == (byte)OPERATION.ADD &&
-						(
-							change.PreviousValue == null ||
-							Equals(change.PreviousValue, container.GetTypeDefaultValue())
-						)
+						change.PreviousValue != change.Value
 					)
 					{
 						// trigger onAdd
diff --git a/Assets/Colyseus/package.json b/Assets/Colyseus/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "io.colyseus.sdk",
-	"version": "0.16.11",
+	"version": "0.16.12",
 	"displayName": "Colyseus SDK",
 	"description": "Colyseus Multiplayer SDK for Unity",
 	"unity": "2019.1",

Original file line number	Diff line number	Diff line change
`@@ -351,10 +351,7 @@ protected void TriggerChanges(ref List<DataChange> allChanges)`
`351`	`351`	`}`
`352`	`352`	`else if (`
`353`	`353`	`(change.Op & (byte)OPERATION.ADD) == (byte)OPERATION.ADD &&`
`354`		`- (`
`355`		`- change.PreviousValue == null \|\|`
`356`		`- Equals(change.PreviousValue, container.GetTypeDefaultValue())`
`357`		`- )`
	`354`	`+ change.PreviousValue != change.Value`
`358`	`355`	`)`
`359`	`356`	`{`
`360`	`357`	`// trigger onAdd`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "io.colyseus.sdk",`
`3`		`- "version": "0.16.11",`
	`3`	`+ "version": "0.16.12",`
`4`	`4`	`"displayName": "Colyseus SDK",`
`5`	`5`	`"description": "Colyseus Multiplayer SDK for Unity",`
`6`	`6`	`"unity": "2019.1",`