Merge pull request #199 from Warchino/fix/improve-remove-callback-index-validation

endel · web-flow · commit 09f5f2c58ddb · 2025-05-05T09:29:08.000-03:00
Fix index validation when removing callback
diff --git a/src/decoder/ReferenceTracker.ts b/src/decoder/ReferenceTracker.ts
@@ -149,8 +149,8 @@ export class ReferenceTracker {
     }
 
     removeCallback(refId: number, field: string | number, callback: Function) {
-        const index = this.callbacks?.[refId]?.[field]?.indexOf(callback);
-        if (index !== -1) {
+        const index: number | undefined = this.callbacks?.[refId]?.[field]?.indexOf(callback);
+        if (index !== undefined && index !== -1) {
             spliceOne(this.callbacks[refId][field], index);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -149,8 +149,8 @@ export class ReferenceTracker {`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`removeCallback(refId: number, field: string \| number, callback: Function) {`
`152`		`- const index = this.callbacks?.[refId]?.[field]?.indexOf(callback);`
`153`		`- if (index !== -1) {`
	`152`	`+ const index: number \| undefined = this.callbacks?.[refId]?.[field]?.indexOf(callback);`
	`153`	`+ if (index !== undefined && index !== -1) {`
`154`	`154`	`spliceOne(this.callbacks[refId][field], index);`
`155`	`155`	`}`
`156`	`156`	`}`