Callbacks: trigger onAdd if .previousValue !== .value #197

Author: endel

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@colyseus/schema",
-  "version": "3.0.33",
+  "version": "3.0.34",
   "description": "Binary state serializer with delta encoding for games",
   "bin": {
     "schema-codegen": "bin/schema-codegen",

src/decoder/strategy/StateCallbacks.ts

@@ -185,7 +185,10 @@ export function getDecoderStateCallbacks<T extends Schema>(decoder: Decoder<T>):
                         }
                     }
 
-                } else if ((change.op & OPERATION.ADD) === OPERATION.ADD && change.previousValue === undefined) {
+                } else if (
+                    (change.op & OPERATION.ADD) === OPERATION.ADD &&
+                    change.previousValue !== change.value
+                ) {
                     // triger onAdd
                     const addCallbacks = $callbacks[OPERATION.ADD];
                     for (let i = addCallbacks?.length - 1; i >= 0; i--) {

test/ArraySchema.test.ts

@@ -1,7 +1,7 @@
 import * as assert from "assert";
 
 import { State, Player, getCallbacks, getEncoder, createInstanceFromReflection, getDecoder, assertDeepStrictEqualEncodeAll, assertRefIdCounts } from "./Schema";
-import { ArraySchema, Schema, type, Reflection, $changes, MapSchema, ChangeTree } from "../src";
+import { ArraySchema, Schema, type, Reflection, $changes, MapSchema, ChangeTree, schema } from "../src";
 
 describe("ArraySchema Tests", () => {
 

test/callbacks/StateCallbacks.test.ts

@@ -256,7 +256,7 @@ describe("StateCallbacks", () => {
     });
 
     describe("ArraySchema", () => {
-        xit("consecutive shift + unshift should trigger onAdd at 0 index", () => {
+        it("consecutive shift + unshift should trigger onAdd at 0 index", () => {
             class Card extends Schema {
                 @type("string") suit: string;
                 @type("number") num: number;