StateView: fix removing child Schema instances from visible set

Author: endel

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@colyseus/schema",
-  "version": "3.0.37",
+  "version": "3.0.38",
   "description": "Binary state serializer with delta encoding for games",
   "bin": {
     "schema-codegen": "bin/schema-codegen",

package.json

@@ -237,6 +237,11 @@ export class StateView {
                 // DELETE / DELETE BY REF ID
                 changes[changeTree.parentIndex] = OPERATION.DELETE;
 
+                // Remove child schema from visible set
+                changeTree.forEachChild((childChangeTree) => {
+                    this.visible.delete(childChangeTree);
+                });
+
             } else {
                 // delete all "tagged" properties.
                 metadata?.[$viewFieldIndexes]?.forEach((index) =>

src/encoder/StateView.ts

@@ -1122,6 +1122,41 @@ describe("StateView", () => {
 
             assert.deepStrictEqual(client.state.items.get("1").toJSON(), item1.toJSON());
         });
+
+        it("view.remove() should remove nested items", () => {
+            class Coordinates extends Schema {
+                @type("number") x: number;
+                @type("number") y: number;
+            }
+            class Diamond extends Schema {
+                @type(Coordinates) position: Coordinates;
+            }
+            class State extends Schema {
+                @view() @type({ map: Diamond }) diamonds = new MapSchema<Diamond>();
+            }
+
+            const state = new State();
+            const encoder = getEncoder(state);
+
+            const diamond = new Diamond().assign({
+                position: new Coordinates().assign({ x: 10, y: 20 })
+            });
+            state.diamonds.set("one", diamond);
+
+            const client1 = createClientWithView(state);
+            client1.view.add(diamond);
+            encodeMultiple(encoder, state, [client1]);
+
+            client1.view.remove(diamond);
+            encodeMultiple(encoder, state, [client1]);
+
+            diamond.position.x++;
+            encodeMultiple(encoder, state, [client1]);
+
+            assert.doesNotThrow(() =>
+                encodeAllMultiple(encoder, state, [client1]));
+        });
+
     });
 
     describe("ArraySchema", () => {