Merge pull request #190 from sylvainpolletvillard/arrayschema-with-negative-indexes

fix ArraySchema#with with negative indexes

Author: endel

src/types/custom/ArraySchema.ts

@@ -722,6 +722,8 @@ export class ArraySchema<V = any> implements Array<V>, Collection<number, V> {
     //
     with(index: number, value: V): ArraySchema<V> {
         const copy = this.items.slice();
+        // Allow negative indexing from the end
+        if (index < 0) index += this.length;
         copy[index] = value;
         return new ArraySchema(...copy);
     }

test/ArraySchema.test.ts

@@ -1840,6 +1840,13 @@ describe("ArraySchema Tests", () => {
             assert.strictEqual(undefined, arr.at(5));
             assert.strictEqual(undefined, arr.at(-6));
         });
+
+        it("#with()", () => {
+			const arr = new ArraySchema<number>(1, 2, 3, 4, 5);
+			assert.deepStrictEqual([1, 6, 3, 4, 5], arr.with(1, 6).toJSON());
+            assert.deepStrictEqual([1, 2, 3, 4, 7], arr.with(-1, 7).toJSON());
+            assert.deepStrictEqual([1, 2, 3, 8, 5], arr.with(-2, 8).toJSON());
+		});
     })
 
     describe("ArraySchema <-> Array type interchangability", () => {