What happened
On PR #1795, the human reviewer (simonbaird) identified that "roxctl" must always be written in lowercase, citing the official Red Hat documentation. The PR's Antora docs used inconsistent casing. Neither the fullsend review agent nor the qodo bot flagged this — it was caught only by the human reviewer's domain knowledge. The review agent's style sub-agent had no source of truth for product name conventions in this repo.
What could go better
The review agent has a style-conventions sub-agent that checks code and docs against repo conventions documented in AGENTS.md. However, AGENTS.md for conforma/policy does not document Red Hat product-name casing rules. Without this guidance, the agent cannot distinguish correct casing from incorrect casing for domain-specific terms like roxctl, cosign, Tekton, Sigstore, etc. This is a high-confidence finding — the gap is clearly in the repo's documentation, not in the agent infrastructure. The existing AGENTS.md has detailed code style conventions for Rego but nothing about product/tool naming conventions in documentation and comments.
Proposed change
Add a "Product and tool name conventions" subsection to the AGENTS.md code style section. Include at minimum: roxctl (always lowercase, per Red Hat docs), and any other product names with specific casing requirements used in this codebase (e.g., cosign, Sigstore, Rekor, Fulcio, Tekton, SLSA). Reference the authoritative Red Hat documentation style guide or product-specific pages where applicable. This gives both human contributors and the review agent a single source of truth for terminology.
Validation criteria
On the next PR that introduces or modifies documentation referencing Red Hat product names, the review agent's style sub-agent should flag any casing violations against the documented conventions. Verify by checking 3-5 subsequent PRs that touch Antora docs or code comments with product name references.
Generated by retro agent from #1795
What happened
On PR #1795, the human reviewer (simonbaird) identified that "roxctl" must always be written in lowercase, citing the official Red Hat documentation. The PR's Antora docs used inconsistent casing. Neither the fullsend review agent nor the qodo bot flagged this — it was caught only by the human reviewer's domain knowledge. The review agent's style sub-agent had no source of truth for product name conventions in this repo.
What could go better
The review agent has a style-conventions sub-agent that checks code and docs against repo conventions documented in AGENTS.md. However, AGENTS.md for conforma/policy does not document Red Hat product-name casing rules. Without this guidance, the agent cannot distinguish correct casing from incorrect casing for domain-specific terms like
roxctl,cosign,Tekton,Sigstore, etc. This is a high-confidence finding — the gap is clearly in the repo's documentation, not in the agent infrastructure. The existing AGENTS.md has detailed code style conventions for Rego but nothing about product/tool naming conventions in documentation and comments.Proposed change
Add a "Product and tool name conventions" subsection to the AGENTS.md code style section. Include at minimum:
roxctl(always lowercase, per Red Hat docs), and any other product names with specific casing requirements used in this codebase (e.g.,cosign,Sigstore,Rekor,Fulcio,Tekton,SLSA). Reference the authoritative Red Hat documentation style guide or product-specific pages where applicable. This gives both human contributors and the review agent a single source of truth for terminology.Validation criteria
On the next PR that introduces or modifies documentation referencing Red Hat product names, the review agent's style sub-agent should flag any casing violations against the documented conventions. Verify by checking 3-5 subsequent PRs that touch Antora docs or code comments with product name references.
Generated by retro agent from #1795