Skip to content

renovate: update all monorepo modules always together #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

renovate: update all monorepo modules always together #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd781a9
renovate: add Tim as reviewer for VM image bumps
Luap99 Nov 7, 2025
b49c089
renovate: update all monorepo modules always together
Luap99 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion renovate/defaults.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,18 @@ and/or use the pre-commit hook: https://github.com/renovatebot/pre-commit-hooks
"enabled": false
},

// Updates for the monorepo modules should be grouped into a single PR.
{
Copy link
Collaborator

@mtrmac mtrmac Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would presumably replace a similar configuration in Podman.

Applying this also to Buildah and Skopeo makes sense.

I don’t know what this will do inside container-libs; it probably doesn’t really — I guess it would make a difference only if some out-of-container-libs consumer wanted to update one, but not all, of the modules to a more recent commit (not tag).

Copy link
Member Author

@Luap99 Luap99 Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would presumably replace a similar configuration in Podman.

Right, I will remove the podman config.

I don’t know what this will do inside container-libs; it probably doesn’t really

Note in general this only groups updates into a single PR. It does not mean all updates get applied at once. If say there is only a common update available renovate still makes a PR with just that. If there is then also an image update it pushed that into the same PR.

SO AFAICT if renovate would try to update the modules in the monorepo it would have done so already itself with or without this extra config.

Copy link
Collaborator

@mtrmac mtrmac Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO AFAICT if renovate would try to update the modules in the monorepo it would have done so already itself with or without this extra config.

OK, that’s clearly fine.

"matchCategories": ["golang"],
"groupName": "common, image, and storage deps",
"schedule": "before 11am on the first day of the week",
"matchPackageNames": [
"/^go.podman.io/common/",
"/^go.podman.io/image/",
"/^go.podman.io/storage/"
]
},

/*************************************************
************ CI configuration options ************
**************************************************/
Expand All @@ -221,7 +233,7 @@ and/or use the pre-commit hook: https://github.com/renovatebot/pre-commit-hooks
"matchFileNames": [".cirrus.yml"],
"groupName": "CI VM Image",
// Somebody(s) need to check image update PRs as soon as they open.
"reviewers": ["Luap99"],
"reviewers": ["Luap99", "timcoding1988"],
// Don't wait, roll out CI VM Updates immediately
"schedule": ["at any time"]
},
Expand Down