Skip to content

Conversation

@askervin
Copy link
Collaborator

No description provided.

@askervin askervin marked this pull request as draft September 19, 2025 07:44
@askervin askervin force-pushed the 5d8_balloons_cstates branch from 082ed24 to 8e7aade Compare September 19, 2025 12:11
@askervin
Copy link
Collaborator Author

Depends on intel/goresctrl#158

@askervin askervin force-pushed the 5d8_balloons_cstates branch from 7690e23 to 84a799b Compare September 23, 2025 10:29
@klihub
Copy link
Collaborator

klihub commented Sep 26, 2025

Haven't really looked at this, but as a nit you seem to lack a sign-off.

@askervin
Copy link
Collaborator Author

Haven't really looked at this, but as a nit you seem to lack a sign-off.

@klihub, this is the first time ever when I did it by purpose... It's the HACK commit that switches to use goresctrl from askervin's github branch with cstates support in it. I did not want to get that commit merged even accidently, so I thought that one way to get red flags would be leaving it unsigned. I'll fix it when the goresctrl PR is merged.

@askervin askervin force-pushed the 5d8_balloons_cstates branch from 84a799b to e040080 Compare October 15, 2025 13:06
@askervin askervin force-pushed the 5d8_balloons_cstates branch from e040080 to 5c00552 Compare October 17, 2025 11:10
@askervin askervin marked this pull request as ready for review October 17, 2025 11:11
@askervin
Copy link
Collaborator Author

Now that intel/goresctrl#158 is merged and I've updated go.mod to pick the latest goresctrl from current main branch, this feature is ready for review. Rebased on top of nri-plugins to make sure tests are passing with the latest e2e changes, too. Looks good.

@askervin askervin marked this pull request as draft October 24, 2025 12:36
@askervin
Copy link
Collaborator Author

Converted to Draft.

Let's get @marquiz 's improvements in cstates filtering: intel/goresctrl#163 and tag goresctrl release, then update this PR to use new filtering before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants