-
Notifications
You must be signed in to change notification settings - Fork 31
Balloons: enabling disabling c-states in latency-critical balloons #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
082ed24 to
8e7aade
Compare
|
Depends on intel/goresctrl#158 |
7690e23 to
84a799b
Compare
|
Haven't really looked at this, but as a nit you seem to lack a sign-off. |
@klihub, this is the first time ever when I did it by purpose... It's the HACK commit that switches to use goresctrl from askervin's github branch with cstates support in it. I did not want to get that commit merged even accidently, so I thought that one way to get red flags would be leaving it unsigned. I'll fix it when the goresctrl PR is merged. |
84a799b to
e040080
Compare
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Antti Kervinen <[email protected]>
e040080 to
5c00552
Compare
|
Now that intel/goresctrl#158 is merged and I've updated go.mod to pick the latest goresctrl from current main branch, this feature is ready for review. Rebased on top of nri-plugins to make sure tests are passing with the latest e2e changes, too. Looks good. |
|
Converted to Draft. Let's get @marquiz 's improvements in cstates filtering: intel/goresctrl#163 and tag goresctrl release, then update this PR to use new filtering before merging. |
No description provided.