Skip to content

Commit 7628fd8

Browse files
Merge branch 'v2-beta-dev' into enh/dx-362-inquirer-v12
2 parents f95b012 + fbdf372 commit 7628fd8

File tree

9 files changed

+2740
-4350
lines changed

9 files changed

+2740
-4350
lines changed

.talismanrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
fileignoreconfig:
22
- filename: pnpm-lock.yaml
3-
checksum: 160c630237c8460589759ddf1a86c3e932b18986c9bbbd96ff69d3bf3f61eb3c
3+
checksum: 2845e79bd5176da75694132383ef026ab8f1a7dc31a1e0472c3950f7d2df0a2b
44
- filename: package-lock.json
5-
checksum: a230db8eb9df6f77e249d47c14b54ac18f4b971c25358d2e0a17e22eb1bd1b48
5+
checksum: a227bddb54a87ad21f9d1400fb4f9f2b98a87153d8263200dd3ce3de9b29b9d9
66
- filename: packages/contentstack-audit/src/modules/entries.ts
77
checksum: 8ad10d72522433bc5ce66079248aa2dabae1758ee63335024efd8526d76dd885
88
- filename: packages/contentstack-config/src/utils/region-handler.ts

package-lock.json

Lines changed: 41 additions & 52 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/contentstack-export/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"dependencies": {
88
"@contentstack/cli-command": "~2.0.0-beta",
99
"@contentstack/cli-utilities": "~2.0.0-beta",
10-
"@contentstack/cli-variants": "~2.0.0-beta.5",
10+
"@contentstack/cli-variants": "~2.0.0-beta.6",
1111
"@oclif/core": "^4.8.0",
1212
"async": "^3.2.6",
1313
"big-json": "^3.2.0",

packages/contentstack-import/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"@contentstack/cli-audit": "~2.0.0-beta.5",
99
"@contentstack/cli-command": "~2.0.0-beta",
1010
"@contentstack/cli-utilities": "~2.0.0-beta",
11-
"@contentstack/cli-variants": "~2.0.0-beta.5",
11+
"@contentstack/cli-variants": "~2.0.0-beta.6",
1212
"@oclif/core": "^4.3.0",
1313
"big-json": "^3.2.0",
1414
"bluebird": "^3.7.2",

packages/contentstack-variants/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/cli-variants",
3-
"version": "2.0.0-beta.5",
3+
"version": "2.0.0-beta.6",
44
"description": "Variants plugin",
55
"main": "lib/index.js",
66
"types": "lib/index.d.ts",

packages/contentstack-variants/src/import/experiences.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,9 +272,11 @@ export default class Experiences extends PersonalizationAdapter<ImportConfig> {
272272
let versionReqObj = lookUpAudiences(version, this.audiencesUid) as CreateExperienceVersionInput;
273273
versionReqObj = lookUpEvents(version, this.eventsUid) as CreateExperienceVersionInput;
274274

275-
if (versionReqObj && versionReqObj.status) {
275+
if (versionReqObj && versionReqObj.status && (versionReqObj.variants?.length ?? 0) > 0) {
276276
versionMap[versionReqObj.status] = versionReqObj;
277277
log.debug(`Mapped version with status: ${versionReqObj.status}`, this.config.context);
278+
} else if (versionReqObj?.status && !(versionReqObj.variants?.length ?? 0)) {
279+
log.warn(`Skipping version ${versionReqObj.status}: no valid variants (all had unmapped Lytics audiences)`, this.config.context);
278280
}
279281
});
280282

packages/contentstack-variants/src/utils/audiences-helper.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ export const lookUpAudiences = (
6565
const expVariations = experience.variants[index];
6666
log.debug(`Processing variant ${index + 1}/${experience.variants.length} of type: ${expVariations['__type']}`);
6767

68-
if (expVariations['__type'] === 'SegmentedVariant' && expVariations?.audiences?.length) {
69-
log.debug(`Found ${expVariations.audiences.length} audiences in SegmentedVariant`);
70-
updateAudiences(expVariations.audiences, audiencesUid);
71-
72-
if (!expVariations.audiences.length) {
68+
if (expVariations['__type'] === 'SegmentedVariant' && (expVariations?.audiences?.length || expVariations?.lyticsAudiences?.length)) {
69+
log.debug(`Found ${expVariations.audiences?.length ?? 0} audiences in SegmentedVariant`);
70+
if (expVariations?.audiences?.length) updateAudiences(expVariations.audiences, audiencesUid);
71+
if (expVariations?.lyticsAudiences?.length) updateAudiences(expVariations.lyticsAudiences, audiencesUid);
72+
if (!(expVariations.audiences?.length || expVariations?.lyticsAudiences?.length)) {
7373
log.warn('No audiences remaining after mapping. Removing variant.');
7474
experience.variants.splice(index, 1);
7575
}

packages/contentstack/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@contentstack/cli-launch": "^1.9.6",
3939
"@contentstack/cli-migration": "~2.0.0-beta.5",
4040
"@contentstack/cli-utilities": "~2.0.0-beta",
41-
"@contentstack/cli-variants": "~2.0.0-beta.5",
41+
"@contentstack/cli-variants": "~2.0.0-beta.6",
4242
"@contentstack/management": "~1.27.6",
4343
"@contentstack/utils": "~1.7.0",
4444
"@oclif/core": "^4.8.0",

0 commit comments

Comments
 (0)