CBG-2318: Rename public channel const (#7793)

Author: bbrks

auth/auth.go

@@ -274,7 +274,7 @@ func (auth *Authenticator) rebuildCollectionChannels(princ Principal, scope, col
 	}
 
 	// always grant access to the public document channel
-	channels.AddChannel(ch.DocumentStarChannel, 1)
+	channels.AddChannel(ch.DocumentPublicChannel, 1)
 
 	channelHistory := auth.calculateHistory(princ.Name(), ca.GetChannelInvalSeq(), ca.InvalidatedChannels(), channels, ca.ChannelHistory())
 

channels/set.go

@@ -26,9 +26,9 @@ const (
 )
 
 // Constants for the * channel variations
-const UserStarChannel = "*"     // user channel for "can access all docs"
-const DocumentStarChannel = "!" // doc channel for "visible to all users"
-const AllChannelWildcard = "*"  // wildcard for 'all channels'
+const UserStarChannel = "*"       // user channel for "can access all docs"
+const DocumentPublicChannel = "!" // doc channel for "visible to all users"
+const AllChannelWildcard = "*"    // wildcard for 'all channels'
 
 // ID represents a single channel inside a collection
 type ID struct {

rest/diagnostic_api.go

@@ -52,7 +52,7 @@ func (h *handler) getAllUserChannelsResponse(user auth.User) (map[string]map[str
 		}
 		resp[keyspace] = make(map[string]channelHistory)
 		for chanName, chanEntry := range currentChannels {
-			if chanName == channels.DocumentStarChannel {
+			if chanName == channels.DocumentPublicChannel {
 				continue
 			}
 			resp[keyspace][chanName] = channelHistory{Entries: []auth.GrantHistorySequencePair{{StartSeq: chanEntry.Sequence, EndSeq: 0}}}