Tidy clang (#179)

* Fix first set of clang-tidy warnings

* Resolve 'cppcoreguidelines-pro-type-member-init' clang-tidy warnings

* Address cppcoreguidelines-avoid-magic-numbers warnings

* Replace forward with move

* Fix some readability issues

* Set enum size

* Fix some naming issues

Author: glynos

.clang-tidy

@@ -5,6 +5,7 @@ Checks: >
   bugprone-*,
   -bugprone-exception-escape,
   -bugprone-easily-swappable-parameters,
+  -bugprone-branch-clone,
   clang-diagnostic-*,
   clang-analyzer-*,
   concurrency-*,
@@ -17,6 +18,7 @@ Checks: >
   -cppcoreguidelines-avoid-c-arrays,
   -cppcoreguidelines-avoid-do-while,
   -cppcoreguidelines-pro-type-reinterpret-cast,
+  -cppcoreguidelines-missing-std-forward,
   misc-*,
   -misc-unused-parameters,
   -misc-non-private-member-variables-in-classes,

.github/workflows/clang-tidy.yml

@@ -54,7 +54,7 @@ jobs:
       - name: Run clang-tidy on source files
         if: false  # Disabled for now
         run: |
-          find tests -name '*.cpp' -print0 | \
+          find examples -name '*.cpp' -print0 | \
             xargs -0 -n1 -P$(nproc) clang-tidy-21 -p build
 
       - name: clang-tidy check passed

.github/workflows/documentation.yml

@@ -43,6 +43,7 @@ jobs:
         run: |
           git clone https://github.com/Microsoft/vcpkg.git
           ./vcpkg/bootstrap-vcpkg.sh
+          vcpkg install nlohmann-json
 
       - name: Configure CMake
         run: |
@@ -51,6 +52,8 @@ jobs:
             -G Ninja \
             -DCMAKE_BUILD_TYPE=Release \
             -DCMAKE_TOOLCHAIN_FILE=${{ github.workspace }}/vcpkg/scripts/buildsystems/vcpkg.cmake \
+            -Dskyr_BUILD_TESTS=OFF \
+            -Dskyr_BUILD_DOCS=ON \
             .
 
       - name: Build documentation

include/skyr/concepts/url_concepts.hpp

@@ -11,22 +11,22 @@
 #include <type_traits>
 
 namespace skyr {
-template <class T, class charT>
-concept is_basic_string = std::is_same_v<std::remove_cv_t<T>, std::basic_string<charT>>;
+template <class T, class CharT>
+concept is_basic_string = std::is_same_v<std::remove_cv_t<T>, std::basic_string<CharT>>;
 
-template <class T, class charT>
-concept is_basic_string_view = std::is_same_v<std::remove_cv_t<T>, std::basic_string_view<charT>>;
+template <class T, class CharT>
+concept is_basic_string_view = std::is_same_v<std::remove_cv_t<T>, std::basic_string_view<CharT>>;
 
-template <class T, class charT>
+template <class T, class CharT>
 concept is_char_array =
-    std::conjunction_v<std::is_array<T>, std::is_same<std::remove_cv_t<std::remove_extent_t<T>>, charT>>;
+    std::conjunction_v<std::is_array<T>, std::is_same<std::remove_cv_t<std::remove_extent_t<T>>, CharT>>;
 
-template <class T, class charT>
-concept is_char_pointer = std::conjunction_v<std::is_pointer<T>, std::is_same<std::remove_pointer_t<T>, charT>>;
+template <class T, class CharT>
+concept is_char_pointer = std::conjunction_v<std::is_pointer<T>, std::is_same<std::remove_pointer_t<T>, CharT>>;
 
-template <class T, class charT>
+template <class T, class CharT>
 concept is_string_container =
-    is_basic_string<T, charT> || is_basic_string_view<T, charT> || is_char_array<T, charT> || is_char_pointer<T, charT>;
+    is_basic_string<T, CharT> || is_basic_string_view<T, CharT> || is_char_array<T, CharT> || is_char_pointer<T, CharT>;
 
 template <typename T>
 concept is_u8_convertible =

include/skyr/containers/static_vector.hpp

@@ -20,7 +20,7 @@ namespace skyr {
 template <class T, std::size_t Capacity>
 class static_vector {
  private:
-  alignas(T) std::array<std::byte, sizeof(T) * Capacity> storage_;
+  alignas(T) std::array<std::byte, sizeof(T) * Capacity> storage_{};
   std::size_t size_ = 0;
 
   auto data_ptr() noexcept -> T* {

include/skyr/core/check_input.hpp

@@ -16,16 +16,18 @@ constexpr static auto is_c0_control_or_space = [](auto byte) {
   return std::iscntrl(byte, std::locale::classic()) || std::isspace(byte, std::locale::classic());
 };
 
-constexpr inline auto remove_leading_c0_control_or_space(std::string_view input, bool* validation_error) {
-  auto first = std::cbegin(input), last = std::cend(input);
+constexpr auto remove_leading_c0_control_or_space(std::string_view input, bool* validation_error) {
+  auto first = std::cbegin(input);
+  auto last = std::cend(input);
   auto it = std::find_if_not(first, last, is_c0_control_or_space);
   *validation_error |= (it != first);
   input.remove_prefix(std::distance(first, it));
   return input;
 }
 
-constexpr inline auto remove_trailing_c0_control_or_space(std::string_view input, bool* validation_error) {
-  auto first = std::crbegin(input), last = std::crend(input);
+constexpr auto remove_trailing_c0_control_or_space(std::string_view input, bool* validation_error) {
+  auto first = std::crbegin(input);
+  auto last = std::crend(input);
   auto it = std::find_if_not(first, last, is_c0_control_or_space);
   *validation_error |= (it != first);
   input.remove_suffix(std::distance(first, it));

include/skyr/core/errors.hpp

@@ -6,12 +6,13 @@
 #ifndef SKYR_CORE_ERRORS_HPP
 #define SKYR_CORE_ERRORS_HPP
 
+#include <cstdint>
 #include <system_error>
 
 namespace skyr {
 /// \enum url_parse_errc
 /// Enumerates URL parser errors
-enum class url_parse_errc {
+enum class url_parse_errc : std::uint8_t {
   /// The string contains an invalid Unicode character
   invalid_unicode_character = 1,
   /// A character is not a valid scheme character

include/skyr/core/host.hpp

@@ -67,17 +67,17 @@ class host {
   ///
   /// \return The host as a string
   [[nodiscard]] auto serialize() const {
-    constexpr static auto serialize = [](auto&& host) -> std::string {
-      using T = std::decay_t<decltype(host)>;
+    constexpr static auto serialize = []<typename T>(T&& host) -> std::string {
+      using host_t = std::decay_t<T>;
 
-      if constexpr (std::is_same_v<T, ipv4_address>) {
+      if constexpr (std::is_same_v<host_t, ipv4_address>) {
         return host.serialize();
-      } else if constexpr (std::is_same_v<T, ipv6_address>) {
+      } else if constexpr (std::is_same_v<host_t, ipv6_address>) {
         return std::format("[{}]", host.serialize());
-      } else if constexpr (std::is_same_v<T, domain_name> || std::is_same_v<T, opaque_host>) {
+      } else if constexpr (std::is_same_v<host_t, domain_name> || std::is_same_v<host_t, opaque_host>) {
         return host.name;
       } else {
-        return std::string();
+        return {};
       }
     };
 
@@ -139,7 +139,7 @@ class host {
   }
 
  private:
-  host_types host_;
+  host_types host_{};
 };
 
 namespace details {

include/skyr/core/parse_query.hpp

@@ -15,8 +15,8 @@
 namespace skyr {
 ///
 struct query_parameter {
-  std::string name;
-  std::optional<std::string> value;
+  std::string name{};
+  std::optional<std::string> value{};
 
   /// Constructor
   query_parameter() = default;

include/skyr/core/schemes.hpp

@@ -13,20 +13,20 @@
 namespace skyr {
 /// \param scheme
 /// \returns
-constexpr inline auto is_special(std::string_view scheme) noexcept -> bool {
+constexpr auto is_special(std::string_view scheme) noexcept -> bool {
   return (scheme == "file") || (scheme == "ftp") || (scheme == "http") || (scheme == "https") || (scheme == "ws") ||
          (scheme == "wss");
 }
 
 /// \param scheme
 /// \returns
-constexpr inline auto default_port(std::string_view scheme) noexcept -> std::optional<std::uint16_t> {
+constexpr auto default_port(std::string_view scheme) noexcept -> std::optional<std::uint16_t> {
   if (scheme == "ftp") {
-    return 21;
+    return 21;  // NOLINT(cppcoreguidelines-avoid-magic-numbers)
   } else if ((scheme == "http") || (scheme == "ws")) {
-    return 80;
+    return 80;  // NOLINT(cppcoreguidelines-avoid-magic-numbers)
   } else if ((scheme == "https") || (scheme == "wss")) {
-    return 443;
+    return 443;  // NOLINT(cppcoreguidelines-avoid-magic-numbers)
   }
   return std::nullopt;
 }