Fix to broken constructors not using defaults (#8)

Fix to completely missed constructor removal

Author: crazycodr

Exceptions/Collection/CollectionException.php

@@ -2,6 +2,7 @@
 
 namespace Exceptions\Collection;
 
+use Exceptions\Helpers\DefaultConstructorTrait;
 use Exceptions\Helpers\DefaultsInterface;
 use Exceptions\Helpers\FromException;
 
@@ -13,7 +14,7 @@
  */
 abstract class CollectionException extends \RuntimeException implements CollectionExceptionInterface, DefaultsInterface
 {
-    use FromException;
+    use FromException, DefaultConstructorTrait;
 
     /**
      * {@inheritdoc}

Exceptions/Data/DataException.php

@@ -2,6 +2,7 @@
 
 namespace Exceptions\Data;
 
+use Exceptions\Helpers\DefaultConstructorTrait;
 use Exceptions\Helpers\DefaultsInterface;
 use Exceptions\Helpers\FromException;
 
@@ -13,7 +14,7 @@
  */
 abstract class DataException extends \RuntimeException implements DataExceptionInterface, DefaultsInterface
 {
-    use FromException;
+    use FromException, DefaultConstructorTrait;
 
     /**
      * {@inheritdoc}

Exceptions/Http/HttpException.php

@@ -2,6 +2,7 @@
 
 namespace Exceptions\Http;
 
+use Exceptions\Helpers\DefaultConstructorTrait;
 use Exceptions\Helpers\DefaultsInterface;
 use Exceptions\Helpers\FromException;
 
@@ -16,7 +17,7 @@
  */
 abstract class HttpException extends \RuntimeException implements HttpExceptionInterface, DefaultsInterface
 {
-    use FromException;
+    use FromException, DefaultConstructorTrait;
 
     /**
      * {@inheritdoc}

Exceptions/IO/IOException.php

@@ -2,6 +2,7 @@
 
 namespace Exceptions\IO;
 
+use Exceptions\Helpers\DefaultConstructorTrait;
 use Exceptions\Helpers\DefaultsInterface;
 use Exceptions\Helpers\FromException;
 
@@ -13,7 +14,7 @@
  */
 abstract class IOException extends \RuntimeException implements IOExceptionInterface, DefaultsInterface
 {
-    use FromException;
+    use FromException, DefaultConstructorTrait;
 
     /**
      * {@inheritdoc}

Exceptions/Operation/OperationException.php

@@ -2,6 +2,7 @@
 
 namespace Exceptions\Operation;
 
+use Exceptions\Helpers\DefaultConstructorTrait;
 use Exceptions\Helpers\DefaultsInterface;
 use Exceptions\Helpers\FromException;
 
@@ -13,7 +14,7 @@
  */
 abstract class OperationException extends \RuntimeException implements OperationExceptionInterface, DefaultsInterface
 {
-    use FromException;
+    use FromException, DefaultConstructorTrait;
 
     /**
      * {@inheritdoc}

Helpers/DefaultConstructorTrait.php

@@ -0,0 +1,15 @@
+<?php
+namespace Exceptions\Helpers;
+
+/**
+ * Defines an easy to reuse constructor that builds the exception using the defaults interface definition
+ *
+ * @package Exceptions
+ */
+trait DefaultConstructorTrait
+{
+    public function __construct(string $message = "", int $code = 0, \Throwable $previous = null)
+    {
+        parent::__construct($message ?: $this->getDefaultMessage(), $code ?: $this->getDefaultCode(), $previous);
+    }
+}

Tests/ExceptionTest.php

@@ -82,6 +82,18 @@ public function testDefaults($className)
         $this->assertNotNull($className::getDefaultCode());
     }
 
+    /**
+     * @dataProvider providesConstructorTestClasses
+     *
+     * @param string $className Class to test that defaults are defined
+     */
+    public function testDefaultConstructor($className)
+    {
+        $exception = new $className();
+        $this->assertEquals($exception->getMessage(), $className::getDefaultMessage());
+        $this->assertEquals($exception->getCode(), $className::getDefaultCode());
+    }
+
     /**
      * @dataProvider providesConstructorTestClasses
      *