Skip to content

Commit 8d3a034

Browse files
committed
posix-cpu-timers: fix race between handle_posix_cpu_timers() and posix_cpu_timer_del()
jira VULN-136693 cve CVE-2025-38352 commit-author Oleg Nesterov <[email protected]> commit f90fff1 If an exiting non-autoreaping task has already passed exit_notify() and calls handle_posix_cpu_timers() from IRQ, it can be reaped by its parent or debugger right after unlock_task_sighand(). If a concurrent posix_cpu_timer_del() runs at that moment, it won't be able to detect timer->it.cpu.firing != 0: cpu_timer_task_rcu() and/or lock_task_sighand() will fail. Add the tsk->exit_state check into run_posix_cpu_timers() to fix this. This fix is not needed if CONFIG_POSIX_CPU_TIMERS_TASK_WORK=y, because exit_task_work() is called before exit_notify(). But the check still makes sense, task_work_add(&tsk->posix_cputimers_work.work) will fail anyway in this case. Cc: [email protected] Reported-by: Benoît Sevens <[email protected]> Fixes: 0bdd2ed ("sched: run_posix_cpu_timers: Don't check ->exit_state, use lock_task_sighand()") Signed-off-by: Oleg Nesterov <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> (cherry picked from commit f90fff1) Signed-off-by: Brett Mastbergen <[email protected]>
1 parent 34084cd commit 8d3a034

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

kernel/time/posix-cpu-timers.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1379,6 +1379,15 @@ void run_posix_cpu_timers(void)
13791379

13801380
lockdep_assert_irqs_disabled();
13811381

1382+
/*
1383+
* Ensure that release_task(tsk) can't happen while
1384+
* handle_posix_cpu_timers() is running. Otherwise, a concurrent
1385+
* posix_cpu_timer_del() may fail to lock_task_sighand(tsk) and
1386+
* miss timer->it.cpu.firing != 0.
1387+
*/
1388+
if (tsk->exit_state)
1389+
return;
1390+
13821391
/*
13831392
* If the actual expiry is deferred to task work context and the
13841393
* work is already scheduled there is no point to do anything here.

0 commit comments

Comments
 (0)