fix: Update cli with selector refactor

Author: adityachoudhari26

cmd/ctrlc/root/api/create/environment/environment.go

@@ -15,7 +15,7 @@ func NewCreateEnvironmentCmd() *cobra.Command {
 	var nameFlag string
 	var releaseChannels []string
 	var system string
-	var resourceFilter string
+	var resourceSelector string
 	var metadata map[string]string
 	cmd := &cobra.Command{
 		Use:   "environment [flags]",
@@ -42,12 +42,12 @@ func NewCreateEnvironmentCmd() *cobra.Command {
 			body.SystemId = system
 			body.Metadata = cliutil.StringMapPtr(metadata)
 
-			if resourceFilter != "" {
-				var parsedFilter map[string]interface{}
-				if err := json.Unmarshal([]byte(resourceFilter), &parsedFilter); err != nil {
-					return fmt.Errorf("failed to parse target filter: %w", err)
+			if resourceSelector != "" {
+				var parsedSelector map[string]interface{}
+				if err := json.Unmarshal([]byte(resourceSelector), &parsedSelector); err != nil {
+					return fmt.Errorf("failed to parse target selector: %w", err)
 				}
-				body.ResourceFilter = &parsedFilter
+				body.ResourceSelector = &parsedSelector
 			}
 
 			resp, err := client.CreateEnvironment(cmd.Context(), body)
@@ -62,7 +62,7 @@ func NewCreateEnvironmentCmd() *cobra.Command {
 	cmd.Flags().StringVarP(&nameFlag, "name", "n", "", "Name of the environment (required)")
 	cmd.Flags().StringVarP(&system, "system", "s", "", "ID of the system (required)")
 	cmd.Flags().StringSliceVarP(&releaseChannels, "release-channel", "r", []string{}, "Release channel in format <channelid>")
-	cmd.Flags().StringVarP(&resourceFilter, "resource-filter", "f", "", "Resource filter as JSON string")
+	cmd.Flags().StringVarP(&resourceSelector, "resource-selector", "f", "", "Resource selector as JSON string")
 	cmd.Flags().StringToStringVarP(&metadata, "metadata", "m", make(map[string]string), "Metadata key-value pairs (e.g. --metadata key=value)")
 
 	cmd.MarkFlagRequired("name")

cmd/ctrlc/root/api/create/releasechannel/release-channel.go

@@ -15,7 +15,7 @@ func NewCreateReleaseChannelCmd() *cobra.Command {
 	var name string
 	var deploymentID string
 	var description string
-	var filter string
+	var selector string
 
 	cmd := &cobra.Command{
 		Use:   "release-channel [flags]",
@@ -36,18 +36,18 @@ func NewCreateReleaseChannelCmd() *cobra.Command {
 				return fmt.Errorf("failed to create API client: %w", err)
 			}
 
-			releaseFilter := make(map[string]interface{})
-			if filter != "" {
-				if err := json.Unmarshal([]byte(filter), &releaseFilter); err != nil {
-					return fmt.Errorf("failed to parse release filter JSON: %w", err)
+			releaseSelector := make(map[string]interface{})
+			if selector != "" {
+				if err := json.Unmarshal([]byte(selector), &releaseSelector); err != nil {
+					return fmt.Errorf("failed to parse release selector JSON: %w", err)
 				}
 			}
 
 			resp, err := client.CreateReleaseChannel(cmd.Context(), api.CreateReleaseChannelJSONRequestBody{
-				Name:          name,
-				DeploymentId:  deploymentID,
-				Description:   &description,
-				ReleaseFilter: releaseFilter,
+				Name:            name,
+				DeploymentId:    deploymentID,
+				Description:     &description,
+				ReleaseSelector: releaseSelector,
 			})
 			if err != nil {
 				return fmt.Errorf("failed to create release channel: %w", err)
@@ -60,7 +60,7 @@ func NewCreateReleaseChannelCmd() *cobra.Command {
 	// Add flags
 	cmd.Flags().StringVar(&name, "name", "", "Name of the release channel (required)")
 	cmd.Flags().StringVar(&deploymentID, "deployment", "", "ID of the deployment (required)")
-	cmd.Flags().StringVar(&filter, "filter", "", "JSON string containing release filter criteria")
+	cmd.Flags().StringVar(&selector, "selector", "", "JSON string containing release selector criteria")
 	cmd.Flags().StringVar(&description, "description", "", "Description of the release channel")
 	cmd.MarkFlagRequired("name")
 	cmd.MarkFlagRequired("deployment-id")

cmd/ctrlc/root/run/exec/runner.go

@@ -39,7 +39,7 @@ func (r *ExecRunner) Status(job api.Job) (api.JobStatus, string) {
 	// to check if process exists
 	err = process.Signal(syscall.Signal(0))
 	if err != nil {
-		return api.JobStatusSuccessful, fmt.Sprintf("process not running: %v", err)
+		return api.JobStatusFailure, fmt.Sprintf("process not running: %v", err)
 	}
 
 	return api.JobStatusInProgress, fmt.Sprintf("process running with pid %d", externalId)