chore: some fields can be readonly (#2394)

Author: asashour

src/models/test_case_hook_definition.ts

@@ -30,11 +30,11 @@ export default class TestCaseHookDefinition
   async getInvocationParameters({
     hookParameter,
   }: IGetInvocationDataRequest): Promise<IGetInvocationDataResponse> {
-    return await Promise.resolve({
+    return {
       getInvalidCodeLengthMessage: () =>
         this.buildInvalidCodeLengthMessage('0 or 1', '2'),
       parameters: [hookParameter],
       validCodeLengths: [0, 1, 2],
-    })
+    }
   }
 }

src/models/test_step_hook_definition.ts

@@ -28,11 +28,11 @@ export default class TestStepHookDefinition
   async getInvocationParameters({
     hookParameter,
   }: IGetInvocationDataRequest): Promise<IGetInvocationDataResponse> {
-    return await Promise.resolve({
+    return {
       getInvalidCodeLengthMessage: () =>
         this.buildInvalidCodeLengthMessage('0 or 1', '2'),
       parameters: [hookParameter],
       validCodeLengths: [0, 1, 2],
-    })
+    }
   }
 }

src/runtime/index.ts

@@ -42,7 +42,7 @@ export default class Runtime implements IRuntime {
   private readonly pickleIds: string[]
   private readonly supportCodeLibrary: SupportCodeLibrary
   private success: boolean
-  private runTestRunHooks: RunsTestRunHooks
+  private readonly runTestRunHooks: RunsTestRunHooks
 
   constructor({
     eventBroadcaster,

src/runtime/parallel/coordinator.ts

@@ -58,8 +58,8 @@ export default class Coordinator implements IRuntime {
   private readonly newId: IdGenerator.NewId
   private readonly pickleIds: string[]
   private assembledTestCases: IAssembledTestCases
-  private inProgressPickles: Record<string, messages.Pickle>
-  private workers: Record<string, IWorker>
+  private readonly inProgressPickles: Record<string, messages.Pickle>
+  private readonly workers: Record<string, IWorker>
   private readonly supportCodeLibrary: SupportCodeLibrary
   private readonly requireModules: string[]
   private readonly requirePaths: string[]

src/user_code_runner_spec.ts

@@ -192,7 +192,7 @@ describe('UserCodeRunner', () => {
         it('returns what the promise resolves to', async function () {
           // Arrange
           const fn = async function (): Promise<string> {
-            return await Promise.resolve('result')
+            return 'result'
           }
 
           // Act
@@ -208,7 +208,7 @@ describe('UserCodeRunner', () => {
         it('returns what the promise rejects as an error', async function () {
           // Arrange
           const fn = async function (): Promise<void> {
-            return await Promise.reject('error') // eslint-disable-line prefer-promise-reject-errors
+            throw 'error'
           }
 
           // Act