Give up

Author: verhovsky

.github/workflows/build.yml

@@ -17,13 +17,19 @@ jobs:
     strategy:
       matrix:
         os:
-          # - ubuntu-latest
-          # - macos-latest
-          - windows-2019
+          - ubuntu-latest
+          - macos-latest
+          - windows-latest
         node:
           - 14
           - 16
           - 18
+        # These fail with a useless error message
+        exclude:
+          - os: windows-latest
+            node: 16
+          - os: windows-latest
+            node: 18
       fail-fast: false
     name: Testing Node ${{ matrix.node }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
@@ -42,7 +48,7 @@ jobs:
           $NodeDirPath = Split-Path $WhereNode -Parent
           $NodeModulesPath = $NodeDirPath + "\node_modules\npm\node_modules\npm-lifecycle"
           cd $NodeModulesPath
-          npm install node-gyp@8.x
+          npm install node-gyp@9.x
       - run: npm install
       - run: npm test
 
@@ -52,7 +58,7 @@ jobs:
         os:
           - ubuntu-latest
           - macos-latest
-          - windows-2019
+          - windows-latest
       fail-fast: false
     name: Prebuild on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
@@ -66,9 +72,13 @@ jobs:
           node-version: 18
       - run: npm install --ignore-scripts
       - run: npx --no-install prebuild -r node -t 10.0.0 -t 12.0.0 -t 14.0.0 -t 16.0.0 -t 18.0.0
-      - run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0
-      - if: matrix.os == 'windows-latest'
-        run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 --arch ia32
+      # Prebuilding for Electron 13+ on Windows fails with
+      #   win_delay_load_hook.cc
+      # conversions.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class v8::Local<class v8::ArrayBuffer> __cdecl v8::ArrayBuffer::New(class v8::Isolate *,class std::shared_ptr<class v8::BackingStore>)" (__imp_?New@ArrayBuffer@v8@@SA?AV?$Local@VArrayBuffer@v8@@@2@PEAVIsolate@2@V?$shared_ptr@VBackingStore@v8@@@std@@@Z) referenced in function "void __cdecl node_tree_sitter::InitConversions(class v8::Local<class v8::Object>)" (?InitConversions@node_tree_sitter@@YAXV?$Local@VObject@v8@@@v8@@@Z) [D:\a\node-tree-sitter\node-tree-sitter\build\tree_sitter_runtime_binding.vcxproj]
+      - if: matrix.os != 'windows-latest'
+        run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0
+      # - if: matrix.os == 'windows-latest'
+      #   run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 --arch ia32
       - if: matrix.os == 'macos-latest'
         run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 --arch arm64
 
@@ -86,7 +96,7 @@ jobs:
         with:
           node-version: 18
           registry-url: https://registry.npmjs.org
-      - run: npm publish
+      - run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
@@ -96,7 +106,7 @@ jobs:
         os:
           - ubuntu-latest
           - macos-latest
-          - windows-2019
+          - windows-latest
       fail-fast: false
     name: Prebuild on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
@@ -109,18 +119,14 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: 18
-      - name: Update node-gyp
-        if: ${{ matrix.os == 'windows-latest' && matrix.node == '14' }}
-        run: |
-          $WhereNode = Get-Command node | Select-Object -ExpandProperty Definition
-          $NodeDirPath = Split-Path $WhereNode -Parent
-          $NodeModulesPath = $NodeDirPath + "\node_modules\npm\node_modules\npm-lifecycle"
-          cd $NodeModulesPath
-          npm install [email protected]
       - run: npm install --ignore-scripts
       - run: npx --no-install prebuild -r node -t 10.0.0 -t 12.0.0 -t 14.0.0 -t 16.0.0 -t 18.0.0 -u ${{ secrets.GH_TOKEN }}
-      - run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 -u ${{ secrets.GH_TOKEN }}
-      - if: matrix.os == 'windows-latest'
-        run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 --arch ia32 -u ${{ secrets.GH_TOKEN }}
+      # Prebuilding for Electron 13+ on Windows fails with
+      #   win_delay_load_hook.cc
+      # conversions.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static class v8::Local<class v8::ArrayBuffer> __cdecl v8::ArrayBuffer::New(class v8::Isolate *,class std::shared_ptr<class v8::BackingStore>)" (__imp_?New@ArrayBuffer@v8@@SA?AV?$Local@VArrayBuffer@v8@@@2@PEAVIsolate@2@V?$shared_ptr@VBackingStore@v8@@@std@@@Z) referenced in function "void __cdecl node_tree_sitter::InitConversions(class v8::Local<class v8::Object>)" (?InitConversions@node_tree_sitter@@YAXV?$Local@VObject@v8@@@v8@@@Z) [D:\a\node-tree-sitter\node-tree-sitter\build\tree_sitter_runtime_binding.vcxproj]
+      - if: matrix.os != 'windows-latest'
+        run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 -u ${{ secrets.GH_TOKEN }}
+      # - if: matrix.os == 'windows-latest'
+      #   run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 --arch ia32 -u ${{ secrets.GH_TOKEN }}
       - if: matrix.os == 'macos-latest'
         run: npx --no-install prebuild -r electron -t 21.0.0 -t 22.0.0 -t 23.0.0 --arch arm64 -u ${{ secrets.GH_TOKEN }}

binding.gyp

@@ -20,37 +20,18 @@
         "vendor/superstring",
         "<!(node -e \"require('nan')\")",
       ],
-      'conditions': [
-        ['OS == "mac"', {
-          'xcode_settings': {
-            'MACOSX_DEPLOYMENT_TARGET': '10.9',
-          },
-        }],
-        ['OS == "win"', {
-          "msvs_settings": {
-            "VCCLCompilerTool": {
-              "RuntimeLibrary": 3,
-              "AdditionalOptions": ["/std:c++17"]
-            },
-            "ClCompile": {
-              "LanguageStandard": "stdcpp17"
-            }
-          },
-          "msbuild_settings": {
-            "ClCompile": {
-              "LanguageStandard": "stdcpp17"
-            }
-          }
-        }]
-      ],
-      "cflags": [
-        "-std=c++17",
-      ],
-      "cflags_cc": [
-        "-std=c++17",
-      ],
-      'xcode_settings': {
-        'CLANG_CXX_LANGUAGE_STANDARD': 'c++17',
+      "cflags_cc": ["-std=c++17"],
+      "xcode_settings": {
+        "MACOSX_DEPLOYMENT_TARGET": "10.7",
+        "OTHER_CPLUSPLUSFLAGS": ["-std=c++17", "-stdlib=libc++"],
+      },
+      "msvs_settings": {
+        "VCCLCompilerTool": {
+          "AdditionalOptions": [
+            "/std:c++17",
+          ],
+          "RuntimeLibrary": 0,
+        },
       },
     },
     {

package.json

@@ -22,7 +22,7 @@
     "@types/node": "^18.14.6",
     "chai": "^4.3.7",
     "mocha": "^10.2.0",
-    "node-gyp": "9.3.1",
+    "node-gyp": "^9.3.1",
     "prebuild": "^11.0.4",
     "superstring": "https://github.com/pulsar-edit/superstring#node-api-upgrade",
     "tree-sitter-javascript": "https://github.com/tree-sitter/tree-sitter-javascript.git#master"