Skip to content

Commit a2a2118

Browse files
committed
Leave only *Handler API
1 parent 3a489f1 commit a2a2118

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
- [ ] Do we need handle methods? Or leave simple bool for transaction and callback only for session lock
1313
- [ ] Should wait mode be blocking or non-blocking by default?
14-
- [ ] Should callback for session lock be at the end of the params?
14+
- [ ] Should callback for session lock be at the end of the params (after optional ones)?
1515

1616
## Introduction
1717

src/Postgres/PostgresAdvisoryLocker.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ public function acquireSessionLevelLock(
9494
* ⚠️ Transaction-level advisory locks are strongly preferred whenever possible,
9595
* as they are automatically released at the end of a transaction and are less error-prone.
9696
* Use session-level locks only when transactional context is not available.
97+
* @see acquireTransactionLevelLock() for preferred locking strategy.
9798
*
9899
* @param PDO $dbConnection Active database connection.
99100
* @param PostgresLockKey $key Lock key to be acquired.
@@ -105,8 +106,6 @@ public function acquireSessionLevelLock(
105106
* @template TReturn
106107
*
107108
* TODO: Cover with tests
108-
*@see acquireTransactionLevelLock() for preferred locking strategy.
109-
*
110109
*/
111110
public function withinSessionLevelLock(
112111
PDO $dbConnection,

0 commit comments

Comments
 (0)