Address some warnings

[MetRonnie]

Spotted in pytest output

datetime.utcnow()

Deprecated since version 3.12: Use datetime.now() with UTC instead.

Note

There is a risk with this because using comparison operators (e.g. <) between timezone-aware and naive (timezone-unaware) datetimes results in a type error. However I cannot find any instances of doing any such comparisons, and all the tests are passing.

sqlite3.connect():

Changed in version 3.13: Positional use of the parameters timeout, detect_types, isolation_level, check_same_thread, factory, cached_statements, and uri is deprecated. They will become keyword-only parameters in Python 3.15.

Check List

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• No dependency changes
• No tests/docs/changelog needed
• If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

[oliver-sanders]

@hjoliver, this PR removes a code block that isn't used any more. Can you have a quick look at it and merge if ok.

[MetRonnie]

@hjoliver ping

[MetRonnie]

@hjoliver, this PR removes a code block that isn't used any more. Can you have a quick look at it and merge if ok.

This code block was previously only used by the Cylc 7 GUI (7.8.15):

cylc-flow/lib/cylc/gui/updater_tree.py

Lines 269 to 277 in e60e8f7

	# Task not finished, but has started and has a meant;
	# so we can compute an expected time of completion.
	tetc_string = (
	self._id_tetc_cache.get(id_, {}).get(tetc_unix))
	if tetc_string is None:
	# We have to calculate it.
	tetc_string = get_time_string_from_unix_time(
	tetc_unix,
	custom_time_zone_info=time_zone_info)

However, even then it looks like it was only used for the same purpose that is already provided by override_use_utc:

cylc-flow/lib/cylc/gui/updater_tree.py

Line 190 in e60e8f7

time_zone_info = self.updater.global_summary.get("time zone info")

cylc-flow/lib/cylc/state_summary_mgr.py

Lines 125 to 128 in e60e8f7

	if get_utc_mode():
	global_summary['time zone info'] = TIME_ZONE_UTC_INFO
	else:
	global_summary['time zone info'] = TIME_ZONE_LOCAL_INFO

[oliver-sanders]

@hjoliver poke

[oliver-sanders]

@hjoliver poke

[oliver-sanders]

(bumped to 8.5.0 as this is non-critical, bump back if merged in time)

[MetRonnie]

Python 3.15 is out next year, hence I think this ought to go in soon (8.7.0 at the latest)