Skip to content

Commit 4ab9ff0

Browse files
authored
Merge branch 'develop' into release/15.0.0
2 parents 4fcb4fd + 17a9ceb commit 4ab9ff0

File tree

4 files changed

+2
-173
lines changed

4 files changed

+2
-173
lines changed

.circleci/workflows.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
version: 2.1
22

3-
chrome-stable-version: &chrome-stable-version "138.0.7204.183"
4-
chrome-beta-version: &chrome-beta-version "139.0.7258.66"
3+
chrome-stable-version: &chrome-stable-version "139.0.7258.66"
4+
chrome-beta-version: &chrome-beta-version "140.0.7339.5"
55
firefox-stable-version: &firefox-stable-version "141.0"
66

77
orbs:

system-tests/__snapshots__/network_error_handling_spec.js

Lines changed: 0 additions & 136 deletions
Original file line numberDiff line numberDiff line change
@@ -237,139 +237,3 @@ exports['e2e network error handling Cypress does not delay a 304 Not Modified be
237237
238238
239239
`
240-
241-
exports['e2e network error handling Cypress tests run as expected 1'] = `
242-
243-
====================================================================================================
244-
245-
(Run Starting)
246-
247-
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
248-
│ Cypress: 1.2.3 │
249-
│ Browser: FooBrowser 88 │
250-
│ Specs: 1 found (network_error_handling.cy.js) │
251-
│ Searched: cypress/e2e/network_error_handling.cy.js │
252-
└────────────────────────────────────────────────────────────────────────────────────────────────┘
253-
254-
255-
────────────────────────────────────────────────────────────────────────────────────────────────────
256-
257-
Running: network_error_handling.cy.js (1 of 1)
258-
259-
260-
network error handling
261-
cy.visit() retries
262-
1) fails after retrying 5x
263-
✓ works on the third try after two failed requests
264-
✓ works on the third try after two 500 errors
265-
✓ re-sends a <form> body on failures
266-
cy.request() retries
267-
2) fails after retrying 5x
268-
✓ works on the third try after two failed requests
269-
✓ works on the third try after two 500 errors
270-
subresource retries
271-
✓ on <img> tags
272-
✓ on <script> tags
273-
274-
275-
7 passing
276-
2 failing
277-
278-
1) network error handling
279-
cy.visit() retries
280-
fails after retrying 5x:
281-
CypressError: \`cy.visit()\` failed trying to load:
282-
283-
http://localhost:13370/immediate-reset?visit
284-
285-
We attempted to make an http request to this URL but the request failed without a response.
286-
287-
We received this error at the network level:
288-
289-
> Error: socket hang up
290-
291-
Common situations why this would fail:
292-
- you don't have internet access
293-
- you forgot to run / boot your web server
294-
- your web server isn't accessible
295-
- you have weird network configuration settings on your computer
296-
[stack trace lines]
297-
298-
From Node.js Internals:
299-
Error: socket hang up
300-
[stack trace lines]
301-
302-
2) network error handling
303-
cy.request() retries
304-
fails after retrying 5x:
305-
CypressError: \`cy.request()\` failed trying to load:
306-
307-
http://localhost:13370/immediate-reset?request
308-
309-
We attempted to make an http request to this URL but the request failed without a response.
310-
311-
We received this error at the network level:
312-
313-
> Error: socket hang up
314-
315-
-----------------------------------------------------------
316-
317-
The request we sent was:
318-
319-
Method: GET
320-
URL: http://localhost:13370/immediate-reset?request
321-
322-
-----------------------------------------------------------
323-
324-
Common situations why this would fail:
325-
- you don't have internet access
326-
- you forgot to run / boot your web server
327-
- your web server isn't accessible
328-
- you have weird network configuration settings on your computer
329-
330-
https://on.cypress.io/request
331-
[stack trace lines]
332-
333-
From Node.js Internals:
334-
RequestError: Error: socket hang up
335-
[stack trace lines]
336-
337-
338-
339-
340-
(Results)
341-
342-
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
343-
│ Tests: 9 │
344-
│ Passing: 7 │
345-
│ Failing: 2 │
346-
│ Pending: 0 │
347-
│ Skipped: 0 │
348-
│ Screenshots: 2 │
349-
│ Video: false │
350-
│ Duration: X seconds │
351-
│ Spec Ran: network_error_handling.cy.js │
352-
└────────────────────────────────────────────────────────────────────────────────────────────────┘
353-
354-
355-
(Screenshots)
356-
357-
- /XXX/XXX/XXX/cypress/screenshots/network_error_handling.cy.js/network error hand (1280x720)
358-
ling -- cy.visit() retries -- fails after retrying 5x (failed).png
359-
- /XXX/XXX/XXX/cypress/screenshots/network_error_handling.cy.js/network error hand (1280x720)
360-
ling -- cy.request() retries -- fails after retrying 5x (failed).png
361-
362-
363-
====================================================================================================
364-
365-
(Run Finished)
366-
367-
368-
Spec Tests Passing Failing Pending Skipped
369-
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
370-
│ ✖ network_error_handling.cy.js XX:XX 9 7 2 - - │
371-
└────────────────────────────────────────────────────────────────────────────────────────────────┘
372-
✖ 1 of 1 failed (100%) XX:XX 9 7 2 - -
373-
374-
375-
`
-2.62 KB
Loading

system-tests/test/network_error_handling_spec.js

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -373,41 +373,6 @@ describe('e2e network error handling', function () {
373373
})
374374
})
375375

376-
it('tests run as expected', function () {
377-
return systemTests.exec(this, {
378-
spec: 'network_error_handling.cy.js',
379-
expectedExitCode: 2,
380-
snapshot: true,
381-
}).then(({ stdout }) => {
382-
// sometimes <img>, <script> get retried, sometimes they do not
383-
384-
if (counts['/immediate-reset?load-img'] > 1) {
385-
console.log('load-img was retried', counts['/immediate-reset?load-img'], 'times')
386-
counts['/immediate-reset?load-img'] = 1
387-
}
388-
389-
if (counts['/immediate-reset?load-js'] > 1) {
390-
console.log('load-js was retried', counts['/immediate-reset?load-js'], 'times')
391-
counts['/immediate-reset?load-js'] = 1
392-
}
393-
394-
expect(counts).to.deep.eq({
395-
'/immediate-reset?visit': 5,
396-
'/immediate-reset?request': 5,
397-
'/immediate-reset?load-img': 1,
398-
'/immediate-reset?load-js': 1,
399-
'/works-third-time-else-500/500-for-request': 3,
400-
'/works-third-time/for-request': 3,
401-
'/works-third-time-else-500/500-for-visit': 3,
402-
'/works-third-time/for-visit': 3,
403-
'/print-body-third-time': 3,
404-
'/print-body-third-time-form': 1,
405-
'/load-img-net-error.html': 1,
406-
'/load-script-net-error.html': 1,
407-
})
408-
})
409-
})
410-
411376
it('does not connect to the upstream proxy for the SNI server request', function () {
412377
const onConnect = sinon.spy(() => {
413378
return true

0 commit comments

Comments
 (0)