Skip to content

Commit 751aa74

Browse files
authored
Merge pull request #667 from danger/node-24-lts
2 parents 0f663eb + f7ed29d commit 751aa74

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
## Master
1515

16+
- Fixed the GitHub Action crashing on every run with `ReferenceError: File is not defined`. The Docker image pinned Node 18, but `danger-js` 14 installs `undici` 7, which needs Node 20.18.1 or newer. The image now installs Node 24, the current LTS. [@orta][] - [#666](https://github.com/danger/swift/issues/666)
1617
- Fixed CI: `yarn global add danger` always installs the latest `danger-js`, whose `content-type` dependency now requires Node >=22, but every CI job installed Node 20 via `setup-node`. Bump `setup-node` to Node 22 across all CI jobs. [@DylanBettermannDD][] - [#665](https://github.com/danger/swift/pull/665)
1718
- Fixed macOS CI: the brew-installed `danger-js` binary embeds a Node 18 older than 18.17, which `undici` 6 requires, so every `fetch()` call (including fetching PR files) threw. Install `danger-js` via `setup-node` + `yarn` on macOS instead, matching the already-passing Linux CI. Also retired the `macos-13` legs (that runner image no longer exists) in favor of `macos-26`. [@DylanBettermannDD][] - [#664](https://github.com/danger/swift/pull/664)
1819

‎Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ LABEL "com.github.actions.color"="blue"
1111
# Install nodejs and Danger
1212
RUN apt-get update -q \
1313
&& apt-get install -qy curl make ca-certificates \
14-
&& curl -sL https://deb.nodesource.com/setup_18.x | bash - \
14+
&& curl -sL https://deb.nodesource.com/setup_24.x | bash - \
1515
&& apt-get install -qy nodejs \
1616
&& npm install -g danger \
1717
&& rm -r /var/lib/apt/lists/*

0 commit comments

Comments
 (0)