InterfacePointers::Cvar() returns nothing in x86-64-support-sourcesdk

[Be1zebub]

it works well on master, but it returns nullptr on x86-64-support-sourcesdk

reproduce:

#include <GarrysMod/Lua/Interface.h>
#include <GarrysMod/Interfaces.hpp>
#include <GarrysMod/InterfacePointers.hpp>
#include <icvar.h>

GMOD_MODULE_OPEN() {
    ICvar* icvar = InterfacePointers::Cvar();
    if (!icvar) {
        LUA->PushSpecial(GarrysMod::Lua::SPECIAL_GLOB);
        LUA->GetField(-1, "print");
        LUA->PushString("Failed to get ICvar interface!");
        LUA->Call(1, 0);
    	LUA->Pop();
    }
    
    return 0;
}

[magnalunar]

You need to make a little changes in the ResolveSymbol function:

template<class T>
static inline T *ResolveSymbol(
	SourceSDK::FactoryLoader &loader, const Symbol &symbol
)
{
	if( symbol.type == Symbol::Type::None )
		return nullptr;

#if defined SYSTEM_WINDOWS

	/*auto iface = reinterpret_cast<T **>( symbol_finder.Resolve(
		loader.GetModule( ), symbol.name.c_str( ), symbol.length
	) );
	return iface != nullptr ? *iface : nullptr;*/

	auto iface = reinterpret_cast<T *>( symbol_finder.Resolve(
		loader.GetModule( ), symbol.name.c_str( ), symbol.length
	) );
	return iface != nullptr ? iface : nullptr;

#elif defined SYSTEM_POSIX

	return reinterpret_cast<T *>( symbol_finder.Resolve(
		loader.GetModule( ), symbol.name.c_str( ), symbol.length
	) );

#endif

}

After this changes, the remaining interfaces will be dereferenced correctly for Windows platform.

By the way, the solution to your issue is found in the previous post.

[Be1zebub]

hi, im using linux.
so its not a point.

[magnalunar]

In that case, you should provide more information about your issue because everything works fine for me when cloning from x86-64-support-sourcesdk repository. Another way, your problem is no longer relevant.

[danielga]

The symbols might be outdated.