testcppcheck.cpp: mitigated passedByValue selfcheck warnings

firewave · firewave · commit bb39b5488b36 · 2025-07-07T14:57:42.000+02:00
diff --git a/test/testcppcheck.cpp b/test/testcppcheck.cpp
@@ -122,7 +122,7 @@ class TestCppcheck : public TestFixture {
         ASSERT(foundMissingIncludeSystem);
     }
 
-    static std::string exename(std::string exe)
+    static std::string exename(const std::string& exe)
     {
 #ifdef _WIN32
         return exe + ".exe";
@@ -133,7 +133,8 @@ class TestCppcheck : public TestFixture {
 
     CppCheck::ExecuteCmdFn getExecuteCommand(int& called) const
     {
-        // NOLINTNEXTLINE(performance-unnecessary-value-param)
+        // cppcheck-suppress passedByValue - used as callback so we need to preserve the signature
+        // NOLINTNEXTLINE(performance-unnecessary-value-param) - used as callback so we need to preserve the signature
         return [&](std::string exe, std::vector<std::string> args, std::string redirect, std::string& /*output*/) -> int {
             ++called;
             if (exe == exename("clang-tidy"))

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ class TestCppcheck : public TestFixture {`
`122`	`122`	`ASSERT(foundMissingIncludeSystem);`
`123`	`123`	`}`
`124`	`124`
`125`		`- static std::string exename(std::string exe)`
	`125`	`+ static std::string exename(const std::string& exe)`
`126`	`126`	`{`
`127`	`127`	`#ifdef _WIN32`
`128`	`128`	`return exe + ".exe";`
`@@ -133,7 +133,8 @@ class TestCppcheck : public TestFixture {`
`133`	`133`
`134`	`134`	`CppCheck::ExecuteCmdFn getExecuteCommand(int& called) const`
`135`	`135`	`{`
`136`		`- // NOLINTNEXTLINE(performance-unnecessary-value-param)`
	`136`	`+ // cppcheck-suppress passedByValue - used as callback so we need to preserve the signature`
	`137`	`+ // NOLINTNEXTLINE(performance-unnecessary-value-param) - used as callback so we need to preserve the signature`
`137`	`138`	`return [&](std::string exe, std::vector<std::string> args, std::string redirect, std::string& /output/) -> int {`
`138`	`139`	`++called;`
`139`	`140`	`if (exe == exename("clang-tidy"))`