From af5964a11218ee6148b3a6681fa191636ba6ddde Mon Sep 17 00:00:00 2001 From: tstrg Date: Sat, 4 Jun 2022 21:02:44 +0200 Subject: [PATCH 1/6] Suggestions box falsely displayed on top of widget https://github.com/danvick/flutter_chips_input/issues/104 --- lib/src/chips_input.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/src/chips_input.dart b/lib/src/chips_input.dart index 3c10a20d..c2f62070 100644 --- a/lib/src/chips_input.dart +++ b/lib/src/chips_input.dart @@ -288,7 +288,11 @@ class ChipsInputState extends State> Future.delayed(const Duration(milliseconds: 300), () { WidgetsBinding.instance.addPostFrameCallback((_) async { final renderBox = context.findRenderObject() as RenderBox; - await Scrollable.of(context)?.position.ensureVisible(renderBox); + await Scrollable.of(context)?.position.ensureVisible(renderBox).then(() { + WidgetsBinding.instance?.addPostFrameCallback(() { + _suggestionsBoxController.overlayEntry?.markNeedsBuild(); + }); + }); }); }); } From 0af2aa2aa170a5a2f683febccea793bba9094d63 Mon Sep 17 00:00:00 2001 From: tstrg Date: Sat, 4 Jun 2022 21:37:45 +0200 Subject: [PATCH 2/6] Fixed missing argument type --- lib/src/chips_input.dart | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/src/chips_input.dart b/lib/src/chips_input.dart index c2f62070..de8d5e90 100644 --- a/lib/src/chips_input.dart +++ b/lib/src/chips_input.dart @@ -288,10 +288,13 @@ class ChipsInputState extends State> Future.delayed(const Duration(milliseconds: 300), () { WidgetsBinding.instance.addPostFrameCallback((_) async { final renderBox = context.findRenderObject() as RenderBox; - await Scrollable.of(context)?.position.ensureVisible(renderBox).then(() { - WidgetsBinding.instance?.addPostFrameCallback(() { + await Scrollable.of(context) + ?.position + .ensureVisible(renderBox) + .then((_) async { + WidgetsBinding.instance.addPostFrameCallback((_) { _suggestionsBoxController.overlayEntry?.markNeedsBuild(); - }); + }); }); }); }); From 5c15f039b955a33fb27ee6ef8b366496206f0c70 Mon Sep 17 00:00:00 2001 From: tstrg Date: Tue, 14 Jun 2022 11:46:10 +0200 Subject: [PATCH 3/6] Web - fix entering more than one character https://github.com/danvick/flutter_chips_input/issues/34 --- lib/src/chips_input.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/src/chips_input.dart b/lib/src/chips_input.dart index de8d5e90..25abc74b 100644 --- a/lib/src/chips_input.dart +++ b/lib/src/chips_input.dart @@ -359,7 +359,9 @@ class ChipsInputState extends State> composing: TextRange.empty, )); } - _closeInputConnectionIfNeeded(); //Hack for #34 (https://github.com/danvick/flutter_chips_input/issues/34#issuecomment-684505282). TODO: Find permanent fix + if( !kIsWeb) { + _closeInputConnectionIfNeeded(); //Hack for #34 (https://github.com/danvick/flutter_chips_input/issues/34#issuecomment-684505282). TODO: Find permanent fix + } _textInputConnection ??= TextInput.attach(this, textInputConfiguration); _textInputConnection?.setEditingState(_value); } From d400d5f6b32193ba556a0b428d900a23b9d8b1a9 Mon Sep 17 00:00:00 2001 From: tstrg Date: Tue, 14 Jun 2022 12:19:43 +0200 Subject: [PATCH 4/6] Web - fix entering more than one character, add kIsWeb Add kIsWeb from package https://github.com/danvick/flutter_chips_input/issues/34 --- lib/src/chips_input.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/src/chips_input.dart b/lib/src/chips_input.dart index 25abc74b..fb892e9b 100644 --- a/lib/src/chips_input.dart +++ b/lib/src/chips_input.dart @@ -3,6 +3,7 @@ import 'dart:math'; import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; +import 'package:flutter/foundation.dart' show kIsWeb; import 'suggestions_box_controller.dart'; import 'text_cursor.dart'; From ffb8f9a08cc4f786d53bcec07fdb51f02dbeda36 Mon Sep 17 00:00:00 2001 From: tstrg Date: Tue, 21 Jun 2022 16:34:09 +0200 Subject: [PATCH 5/6] Trying to fix issue in package:flutter/src/services/text_input.dart. Failed assertion 'attached': is not true Mentioned at Add guard against calling setEditingState in detached mode https://github.com/danvick/flutter_chips_input/pull/17/commits/311939c785f030467f87874472f5c47b2f651f53 --- lib/src/chips_input.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/chips_input.dart b/lib/src/chips_input.dart index fb892e9b..f5c70a36 100644 --- a/lib/src/chips_input.dart +++ b/lib/src/chips_input.dart @@ -364,7 +364,7 @@ class ChipsInputState extends State> _closeInputConnectionIfNeeded(); //Hack for #34 (https://github.com/danvick/flutter_chips_input/issues/34#issuecomment-684505282). TODO: Find permanent fix } _textInputConnection ??= TextInput.attach(this, textInputConfiguration); - _textInputConnection?.setEditingState(_value); + if(_textInputConnection?.attached) _textInputConnection?.setEditingState(_value); } @override From 1b1ed12c9de48aa9a985d838547400792f6b4558 Mon Sep 17 00:00:00 2001 From: tstrg Date: Tue, 21 Jun 2022 16:44:35 +0200 Subject: [PATCH 6/6] Trying to fix issue in package:flutter/src/services/text_input.dart. Failed assertion 'attached': is not true Mentioned at Add guard against calling setEditingState in detached mode https://github.com/danvick/flutter_chips_input/pull/17/commits/311939c785f030467f87874472f5c47b2f651f53 --- lib/src/chips_input.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/chips_input.dart b/lib/src/chips_input.dart index f5c70a36..59da4fa3 100644 --- a/lib/src/chips_input.dart +++ b/lib/src/chips_input.dart @@ -364,7 +364,7 @@ class ChipsInputState extends State> _closeInputConnectionIfNeeded(); //Hack for #34 (https://github.com/danvick/flutter_chips_input/issues/34#issuecomment-684505282). TODO: Find permanent fix } _textInputConnection ??= TextInput.attach(this, textInputConfiguration); - if(_textInputConnection?.attached) _textInputConnection?.setEditingState(_value); + if(_textInputConnection?.attached ?? false) _textInputConnection?.setEditingState(_value); } @override