-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
Is there an existing issue for this?
- I checked and did not find my issue in the already reported ones
Describe the bug
Alt+click to clear and start over does not work when refining a selection (red overlay) on L(ubuntu) 24.04, LXQt, self compiled 5.5.0+659~g6fb9ee1aeb. Also a selection (red overlay) is not cleared when the module is reset.
To double check I replaced in develop/masks/object.c
line 1156 GDK_MOD1_MASK by GDK_SHIFT_MASK and
line 1189 GDK_SHIFT_MASK by GDK_MOD1_MASK
and now I can clear the selection but no longer exclude areas.
And this (line 1156)
if(gui->creation && which == 1 && dt_modifier_is(state, GDK_SHIFT_MASK + GDK_CONTROL_MASK))
allows me to clear with CTRL+SHIFT+click
So the code is OK but ALT modifier ( GDK_MOD1_MASK ) does not work !
In https://docs.gtk.org/gdk3/flags.ModifierType.html one can find :
GDK_MOD1_MASK
The fourth modifier key (it depends on the modifier mapping of the X server which key is interpreted as this modifier, but normally it is the Alt key).
It seems reasonable to me to use other modifier(s) where the key mapping is unambiguous.
Steps to reproduce
- Open image in darkroom
- Open module Exposure
- Select Drawn mask
- Click Icon for Object mask, wait until image is analyzed
- Select area with brush (Click) -> area is shown with red overlay
- ALT+Click to clear this selection -> nothing happens.
Expected behavior
Clear the selection with other modifier(s), clear the selection when module is reset
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
darktable.org / GitHub release
darktable version
5.5.0+659~g6fb9ee1aeb
What OS are you using?
Linux
What is the version of your OS?
L(ubuntu) 24.04
Describe your system
OS : Linux 6.8.0-106-generic / Ubuntu 24.04.4 LTS
Memory : MemTotal: 65759236 kB
Graphics Card : Product Name : NVIDIA GeForce RTX 2060
Graphics Card : Driver Version : 580.126.09
OpenCL installed : Device OpenCL C Version OpenCL C 1.2
OpenCL activated : yes
Xorg : Version: 1:7.7+23ubuntu3
Desktop : LXQt
GTK+ : 3.24.41
Glib : ldd (Ubuntu GLIBC 2.39-0ubuntu8.7) 2.39
gcc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0
Are you using OpenCL GPU in darktable?
Yes
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response