Skip to content

Commit 9e3e125

Browse files
committed
Remove mirrors.
1 parent ca1da49 commit 9e3e125

File tree

6 files changed

+8
-284
lines changed

6 files changed

+8
-284
lines changed

build_runner/lib/src/daemon/daemon_builder.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,8 @@ class BuildRunnerDaemonBuilder implements DaemonBuilder {
7777
(change) => AssetChange(AssetId.parse(change.path), change.type),
7878
)
7979
.toList();
80-
81-
if (!_buildOptions.skipBuildScriptCheck &&
82-
_buildSeries.buildScriptUpdates!.hasBeenUpdated(
83-
changes.map<AssetId>((change) => change.id).toSet(),
84-
)) {
80+
// ignore_for_file: dead_code
81+
if (!_buildOptions.skipBuildScriptCheck && false) {
8582
if (!_buildScriptUpdateCompleter.isCompleted) {
8683
_buildScriptUpdateCompleter.complete();
8784
}

build_runner/lib/src/generate/watch_impl.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,8 @@ class WatchImpl implements BuildState {
257257

258258
_expectedDeletes.clear();
259259
if (!options.skipBuildScriptCheck) {
260-
if (build.buildScriptUpdates!.hasBeenUpdated(
261-
mergedChanges.keys.toSet(),
262-
)) {
260+
// ignore_for_file: dead_code
261+
if (false) {
263262
_terminateCompleter.complete();
264263
buildLog.error('Terminating builds due to build script update.');
265264
return BuildResult(

build_runner_core/lib/src/changes/build_script_updates.dart

Lines changed: 0 additions & 161 deletions
This file was deleted.

build_runner_core/lib/src/generate/build_definition.dart

Lines changed: 4 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import '../asset/writer.dart';
1414
import '../asset_graph/exceptions.dart';
1515
import '../asset_graph/graph.dart';
1616
import '../asset_graph/graph_loader.dart';
17-
import '../changes/build_script_updates.dart';
1817
import '../environment/build_environment.dart';
1918
import '../logging/build_log.dart';
2019
import '../util/constants.dart';
@@ -27,7 +26,6 @@ import 'options.dart';
2726
// not a build definition.
2827
class BuildDefinition {
2928
final AssetGraph assetGraph;
30-
final BuildScriptUpdates? buildScriptUpdates;
3129

3230
/// Whether this is a build starting from no previous state or outputs.
3331
final bool cleanBuild;
@@ -39,12 +37,7 @@ class BuildDefinition {
3937
/// the current build having an incompatible change.
4038
final Map<AssetId, ChangeType>? updates;
4139

42-
BuildDefinition._(
43-
this.assetGraph,
44-
this.buildScriptUpdates,
45-
this.cleanBuild,
46-
this.updates,
47-
);
40+
BuildDefinition._(this.assetGraph, this.cleanBuild, this.updates);
4841

4942
static Future<BuildDefinition> prepareWorkspace(
5043
BuildEnvironment environment,
@@ -77,7 +70,6 @@ class _Loader {
7770
var cacheDirSources = await assetTracker.findCacheDirSources();
7871
var internalSources = await assetTracker.findInternalSources();
7972

80-
BuildScriptUpdates? buildScriptUpdates;
8173
Map<AssetId, ChangeType>? updates;
8274
var cleanBuild = true;
8375
if (assetGraph != null) {
@@ -90,17 +82,8 @@ class _Loader {
9082
cacheDirSources,
9183
internalSources,
9284
);
93-
buildScriptUpdates = await BuildScriptUpdates.create(
94-
_environment.reader,
95-
_options.packageGraph,
96-
assetGraph,
97-
disabled: _options.skipBuildScriptCheck,
98-
);
99-
100-
var buildScriptUpdated =
101-
!_options.skipBuildScriptCheck &&
102-
buildScriptUpdates.hasBeenUpdated(updates.keys.toSet());
103-
if (buildScriptUpdated) {
85+
// ignore_for_file: dead_code
86+
if (false) {
10487
buildLog.fullBuildBecause(FullBuildReason.incompatibleScript);
10588
var deletedSourceOutputs = await assetGraph.deleteOutputs(
10689
_options.packageGraph,
@@ -115,7 +98,6 @@ class _Loader {
11598

11699
inputSources.removeAll(deletedSourceOutputs);
117100
assetGraph = null;
118-
buildScriptUpdates = null;
119101
updates = null;
120102
cleanBuild = true;
121103
}
@@ -137,13 +119,6 @@ class _Loader {
137119
buildLog.error(e.toString());
138120
throw const CannotBuildException();
139121
}
140-
buildScriptUpdates = await BuildScriptUpdates.create(
141-
_environment.reader,
142-
_options.packageGraph,
143-
assetGraph,
144-
disabled: _options.skipBuildScriptCheck,
145-
);
146-
147122
conflictingOutputs =
148123
assetGraph.outputs
149124
.where((n) => n.package == _options.packageGraph.root.name)
@@ -171,12 +146,7 @@ class _Loader {
171146
await _initialBuildCleanup(conflictingOutputs, _environment.writer);
172147
}
173148

174-
return BuildDefinition._(
175-
assetGraph,
176-
buildScriptUpdates,
177-
cleanBuild,
178-
updates,
179-
);
149+
return BuildDefinition._(assetGraph, cleanBuild, updates);
180150
}
181151

182152
/// Deletes the generated output directory.

build_runner_core/lib/src/generate/build_series.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import 'package:watcher/watcher.dart';
1212
import '../asset/finalized_reader.dart';
1313
import '../asset/writer.dart';
1414
import '../asset_graph/graph.dart';
15-
import '../changes/build_script_updates.dart';
1615
import '../environment/build_environment.dart';
1716
import '../logging/build_log.dart';
1817
import '../package_graph/apply_builders.dart';
@@ -39,7 +38,6 @@ import 'options.dart';
3938
class BuildSeries {
4039
final BuildEnvironment environment;
4140
final AssetGraph assetGraph;
42-
final BuildScriptUpdates? buildScriptUpdates;
4341
final BuildOptions options;
4442
final BuildPhases buildPhases;
4543

@@ -66,7 +64,6 @@ class BuildSeries {
6664
BuildSeries._(
6765
this.environment,
6866
this.assetGraph,
69-
this.buildScriptUpdates,
7067
this.options,
7168
this.buildPhases,
7269
this.finalizedReader,
@@ -173,7 +170,6 @@ class BuildSeries {
173170
var build = BuildSeries._(
174171
environment,
175172
buildDefinition.assetGraph,
176-
buildDefinition.buildScriptUpdates,
177173
options,
178174
buildPhases,
179175
finalizedReader,

build_runner_core/test/changes/build_script_updates_test.dart

Lines changed: 0 additions & 77 deletions
This file was deleted.

0 commit comments

Comments
 (0)